Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Issue #7615 HttpServletResponse.encodeURL() should support relative paths #7763

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

gregw
Copy link
Contributor

@gregw gregw commented Mar 21, 2022

  • use presence of scheme to gate parsing as HttpURI

This replaces #7616

Signed-off-by: Greg Wilkins gregw@webtide.com

 + use presence of scheme to gate parsing as HttpURI

Signed-off-by: Greg Wilkins <gregw@webtide.com>
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, this is cleaner.
I like the removal of HttpURI usage too.

@joakime joakime added the Bug For general bugs on Jetty side label Mar 21, 2022
@joakime joakime linked an issue Mar 21, 2022 that may be closed by this pull request
@joakime joakime changed the title Alternate resolution of #7615 Issue #7615 HttpServletResponse.encodeURL() should support relative paths Mar 21, 2022
@gregw gregw merged commit 9c30caf into jetty-9.4.x Mar 21, 2022
@joakime joakime deleted the jetty-9.4.x-7615-encodeURL-alt branch March 21, 2022 14:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Bug For general bugs on Jetty side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpServletResponse.encodeURL not working for URLs starting with ../
2 participants