Fix StatisticsHandler in the case a Handler throws exception. #7837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
|
Having a late point of status tracking, to supplement the tracking in the StatisticsHandler is a good idea. |
|
Note that we have a late stats point in jetty-12, but I don't think we should make significant changes in <= 11 |
gregw
approved these changes
Apr 26, 2022
|
@lachlan-roberts is there an open issue for this? |
|
@joakime yes there is an open private issue which has been linked. |
joakime
added a commit
that referenced
this pull request
May 4, 2022
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
lachlan-roberts
added a commit
that referenced
this pull request
May 6, 2022
Issue #7837 - Fix StatisticsHandler in the case a Handler throws exception.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a
Handlerthrows, theStatisticsHandlerthinks it has seen a 200 response because the status code has not yet been set. This PR adds a separate stat_responsesThrownwhich is now incremented instead of using the incorrect status code in the case the handler throws.