Bring back some openid improvements from 10.0.x to 9.4.x #9660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
joakime
approved these changes
Apr 19, 2023
gregw
approved these changes
Apr 19, 2023
gregw
added
the
Sponsored
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bring back some openid improvements from recent commits to 10.0.x
Development in OpenID has been progressing on 10+ but not many of the changes have been brought back to 9.4. So this brings back some minimal changes.
This brings back testing for the nested login service and using Instant instead of
System.currentTimeMillisfor time calculations as well as the improvedOpenIdProvidertest class.see #9528