Code

DRAFT: Close Middleware Spans Early#1

Code

Draft

jfhbrook-at-work wants to merge 142 commits intohoneycomb-oteljfhbrook-at-work/boltzmann:honeycomb-otelfrom close-middleware-spans-earlyjfhbrook-at-work/boltzmann:close-middleware-spans-earlyCopy head branch name to clipboard

+56,383-3,852

Commits

Commits on Jan 10, 2022

• Initialize OpenTelemetry SDK

  

  Josh Holbrook

  committed
  586ca22

  Copy full SHA for 586ca22

• Create OpenTelemetry root and middleware spans

  

  Josh Holbrook

  committed
  2c010ef

  Copy full SHA for 2c010ef

• Add exit handlers for otel

  

  Josh Holbrook

  committed
  b1ebc2b

  Copy full SHA for b1ebc2b

• Set traceparent and tracestate on the active otel context

  

  Josh Holbrook

  committed
  723fd57

  Copy full SHA for 723fd57

Commits on Jan 13, 2022

• Add otel imports to prelude

  

  Josh Holbrook

  committed
  5cd62d4

  Copy full SHA for 5cd62d4

• Refactor grpc switching logic

  

  Josh Holbrook

  committed
  04aadc8

  Copy full SHA for 04aadc8

Commits on Jan 18, 2022

• Use isHoneycomb/isOtel everywhere, including prelude

  

  Josh Holbrook

  committed
  1dc2e4e

  Copy full SHA for 1dc2e4e

• Export beeline by default

  

  Josh Holbrook

  committed
  654fda9

  Copy full SHA for 654fda9

• Use OpenTelemetry semantic attributes

  

  Josh Holbrook

  committed
  456baf8

  Copy full SHA for 456baf8

• Move isHoneycomb/isOtel tests to prelude

  

  Josh Holbrook

  committed
  6156585

  Copy full SHA for 6156585

• Replace type guards with unsafe casts, yolo

  

  Josh Holbrook

  committed
  548a39f

  Copy full SHA for 548a39f

• Configure sampler

  

  Josh Holbrook

  committed
  9468197

  Copy full SHA for 9468197

• Switch from @opentelemetry/node to @opentelemetry/sdk-trace-node

  

  Josh Holbrook

  committed
  dd3c7fe

  Copy full SHA for dd3c7fe

• Fix deprecation warning

  

  Josh Holbrook

  committed
  3775b0b

  Copy full SHA for 3775b0b

• Use individual node instrumentations

  

  Josh Holbrook

  committed
  267ea46

  Copy full SHA for 267ea46

Commits on Jan 19, 2022

• Change default port to 8000

  

  Josh Holbrook

  committed
  9d4a03e

  Copy full SHA for 9d4a03e

• Update dependencies.ron, clean up unused dependency

  

  Josh Holbrook

  committed
  1ad0488

  Copy full SHA for 1ad0488

• Add @opentelemetry/api dependency

  

  Josh Holbrook

  committed
  81992c8

  Copy full SHA for 81992c8

• set up W3CTraceContextPropagator

  

  Josh Holbrook

  committed
  5838b9e

  Copy full SHA for 5838b9e

• Pretest hook to check typescript types

  

  Josh Holbrook

  committed
  bc6ef01

  Copy full SHA for bc6ef01

• Simplify ts check script

  

  Josh Holbrook

  committed
  80345df

  Copy full SHA for 80345df

• Break otel functionality into unit-test-able functions

  

  Josh Holbrook

  committed
  a7f7fe5

  Copy full SHA for a7f7fe5

• TODOs for instrumentation modules

  

  Josh Holbrook

  committed
  3246ed9

  Copy full SHA for 3246ed9

• Wrap honeycomb env var normalization in a function

  

  Josh Holbrook

  committed
  2df46ce

  Copy full SHA for 2df46ce

• Clean up tap setup in prelude

  

  Josh Holbrook

  committed
  08e4c8c

  Copy full SHA for 08e4c8c

• Remove a bunch of crufty instrumentations and respect postgres + redis feature flags

  

  Josh Holbrook

  committed
  7434dba

  Copy full SHA for 7434dba

Commits on Jan 20, 2022

• a bunch of otel unit tests

  

  Josh Holbrook

  committed
  a278abd

  Copy full SHA for a278abd

• t.equals -> t.equal (the former is deprecated)

  

  Josh Holbrook

  committed
  68a2916

  Copy full SHA for 68a2916

• fix: Add v to version for error-produced urls

  Show description for beec2ab
  

  Jeffrey Lembeck

  authored and

  Josh Holbrook

  committed
  beec2ab

  Copy full SHA for beec2ab

• whack-a-mole deprecated tap APIs

  

  Josh Holbrook

  committed
  eee251b

  Copy full SHA for eee251b

• Don't import middleware/test in prelude tests

  

  Josh Holbrook

  committed
  a9620de

  Copy full SHA for a9620de

• Resolve promise on error when closing parent span

  

  Josh Holbrook

  committed
  ae78d7c

  Copy full SHA for ae78d7c

• Remove testing stubs from honeycomb middleware

  

  Josh Holbrook

  committed
  079d091

  Copy full SHA for 079d091

• Fix template bug

  

  Josh Holbrook

  committed
  f1911e4

  Copy full SHA for f1911e4

• Fix syntax error in dependencies.ron

  

  Josh Holbrook

  committed
  6badf29

  Copy full SHA for 6badf29

Commits on Jan 21, 2022

• push honeycomb into core module

  

  Josh Holbrook

  committed
  acf5f43

  Copy full SHA for acf5f43

Commits on Jan 25, 2022

• Move honeycomb core code out of prelude.ts

  

  Josh Holbrook

  committed
  05442e6

  Copy full SHA for 05442e6

Commits on Jan 28, 2022

• build succeeds! but beelines are broken in the middleware layer, womp womp

  

  Josh Holbrook

  committed
  d663aa5

  Copy full SHA for d663aa5

• Don't try to open/close spans when honeycomb isn't even initialized

  

  Josh Holbrook

  committed
  a331711

  Copy full SHA for a331711

• SMOKE TESTS PASSING

  

  Josh Holbrook

  committed
  c349a5a

  Copy full SHA for c349a5a

Commits on Jan 31, 2022

• Remove otel functionality to create more manageable pull request

  

  Josh Holbrook

  committed
  c2e98a2

  Copy full SHA for c2e98a2

• Remove otel deps

  

  Josh Holbrook

  committed
  11fb7ef

  Copy full SHA for 11fb7ef

• Test the honeycomb trace span name logic

  

  Josh Holbrook

  committed
  aad8bb2

  Copy full SHA for aad8bb2

• boltzmann-cli npm package will now run x64 darwin build on arm

  

  Josh Holbrook

  committed
  f14b5be

  Copy full SHA for f14b5be

Commits on Feb 8, 2022

• Start the trace *after* handling the ping route

  

  Josh Holbrook

  committed
  fb0896d

  Copy full SHA for fb0896d

• Update middleware.ts to use honeycomb abstraction

  

  Josh Holbrook

  committed
  ec89c52

  Copy full SHA for ec89c52

• Revert "Remove otel deps"

  Show description for 5b87272
  

  Josh Holbrook

  committed
  5b87272

  Copy full SHA for 5b87272

• Revert "Remove otel functionality to create more manageable pull request"

  Show description for ea5b018
  

  Josh Holbrook

  committed
  ea5b018

  Copy full SHA for ea5b018

• rename otlp to otel throughout

  

  Josh Holbrook

  committed
  c918f7a

  Copy full SHA for c918f7a

• Remove search querystring from trace span names

  

  Josh Holbrook

  committed
  0d429c1

  Copy full SHA for 0d429c1

• Use HTTP_CLIENT_IP instead of NET_PEER_IP

  

  Josh Holbrook

  committed
  4b253d4

  Copy full SHA for 4b253d4

• Set span kind to SERVER

  

  Josh Holbrook

  committed
  c21535c

  Copy full SHA for c21535c

• Clean up trace propagation code

  

  Josh Holbrook

  committed
  8bc89a1

  Copy full SHA for 8bc89a1

• Fix W3CTraceContextPropagator import

  

  Josh Holbrook

  committed
  ab5cd7a

  Copy full SHA for ab5cd7a

• update core/middleware to use honeycomb facade API

  

  Josh Holbrook

  committed
  4cf40fe

  Copy full SHA for 4cf40fe

Commits on Feb 15, 2022

• Failing test for honeycomb/otel instrumentation

  

  Josh Holbrook

  committed
  27770ca

  Copy full SHA for 27770ca

Commits on Feb 16, 2022

• Respect doNotTrace and fill in test asserts

  

  Josh Holbrook

  committed
  8c3cb94

  Copy full SHA for 8c3cb94

• Attempt to plumb up contexts better

  

  Josh Holbrook

  committed
  297dd6a

  Copy full SHA for 297dd6a

Commits on Feb 17, 2022

• spruced up the test trace propagator

  

  Josh Holbrook

  committed
  1afaf75

  Copy full SHA for 1afaf75

• Extra log lines for honeycomb tracing (parent/child spans not connecting in beelines)

  

  Josh Holbrook

  committed
  71f4c22

  Copy full SHA for 71f4c22

Commits on Feb 21, 2022

• Refactor honeycomb mocking - tests should all use the same mock object now

  

  Josh Holbrook

  committed
  11f72b9

  Copy full SHA for 11f72b9

• Move span/trace up/down logic back into middleware

  

  Josh Holbrook

  committed
  d03cc24

  Copy full SHA for d03cc24

• Traces are now connecting and have the correct service.name

  

  Josh Holbrook

  committed
  939bdc4

  Copy full SHA for 939bdc4

• ignore noisy http auto-instrumentation

  

  Josh Holbrook

  committed
  03a3edb

  Copy full SHA for 03a3edb

Commits on Feb 22, 2022

• WE HAVE INWARD PROPAGATION

  

  Josh Holbrook

  committed
  d386461

  Copy full SHA for d386461

• rename otelAPI to otel (for convenience)

  

  Josh Holbrook

  committed
  d0e60a0

  Copy full SHA for d0e60a0

• Minor cleanup/refactors

  

  Josh Holbrook

  committed
  09b564e

  Copy full SHA for 09b564e

• remove top-level trace span in non-test mode

  

  Josh Holbrook

  committed
  ec8fef7

  Copy full SHA for ec8fef7

• Remove explicit trace context propagator (w3c works automatically)

  

  Josh Holbrook

  committed
  291533c

  Copy full SHA for 291533c

• Remove spans array and use closures instead

  

  Josh Holbrook

  committed
  23d03cb

  Copy full SHA for 23d03cb

• nudge span context property def to make js build happy

  

  Josh Holbrook

  committed
  c5b1eaf

  Copy full SHA for c5b1eaf

• Fill in otel trace URL params

  

  Josh Holbrook

  committed
  5a663c5

  Copy full SHA for 5a663c5

• Use bole for logging in honeycomb middleware

  

  Josh Holbrook

  committed
  ba3a1e9

  Copy full SHA for ba3a1e9

• honeycomb-related logging uses bole when available

  

  Josh Holbrook

  committed
  bb3e472

  Copy full SHA for bb3e472

• type for logger

  

  Josh Holbrook

  committed
  db7900b

  Copy full SHA for db7900b

• Organization/cleanup of core/honeycomb.ts

  

  Josh Holbrook

  committed
  66ba9d9

  Copy full SHA for 66ba9d9

• Refactor how honeycomb mock is created

  

  Josh Holbrook

  committed
  c06513f

  Copy full SHA for c06513f

• Use the traceparent header for the context ID if available

  

  Josh Holbrook

  committed
  ffb9da8

  Copy full SHA for ffb9da8

• context.addTraceAttributes method

  

  Josh Holbrook

  committed
  0b931e7

  Copy full SHA for 0b931e7

• scope otel "trace" attributes to "app." + note on traces vs spans

  

  Josh Holbrook

  committed
  1fdce2e

  Copy full SHA for 1fdce2e

• Fix setting otel "trace" attributes - strike that, reverse it

  

  Josh Holbrook

  committed
  3eea8ff

  Copy full SHA for 3eea8ff

• Upgrade actions from node 12.x to 16.x

  

  Josh Holbrook

  committed
  c00b264

  Copy full SHA for c00b264

• Use node action v2

  

  Josh Holbrook

  committed
  dbfdbfe

  Copy full SHA for dbfdbfe

• Only add properties to otel trace span if defined

  

  Josh Holbrook

  committed
  7be7b08

  Copy full SHA for 7be7b08

• Fixes to make dispensary-dashboard build happy

  

  Josh Holbrook

  committed
  5ede8e9

  Copy full SHA for 5ede8e9

• Update honeycomb-beeline.d.ts in build

  

  Josh Holbrook

  committed
  5eca46b

  Copy full SHA for 5eca46b

• Make dispensary-dashboard happy with honeycomb-beeline.d.ts formatting

  

  Josh Holbrook

  committed
  5786115

  Copy full SHA for 5786115

• Naively upgrade typescript-eslint libraries to fix huge warning in consumer-app-gateway

  

  Josh Holbrook

  committed
  c0c32ed

  Copy full SHA for c0c32ed

Commits on Feb 23, 2022

• Improved comments

  

  Josh Holbrook

  committed
  f6015f8

  Copy full SHA for f6015f8

• Add some extra trace attributes

  

  Josh Holbrook

  committed
  c007bf1

  Copy full SHA for c007bf1

• Refactor "trace attributes" feature

  

  Josh Holbrook

  committed
  e83f46b

  Copy full SHA for e83f46b

• use otel.context.with instead of carrying spans on boltzmann context

  

  Josh Holbrook

  committed
  1105b07

  Copy full SHA for 1105b07

• Wrap honeycomb logging setup in if-block + add deprecation warning

  

  Josh Holbrook

  committed
  a6a3ce7

  Copy full SHA for a6a3ce7

• Minor otel middleware bugfixes

  

  Josh Holbrook

  committed
  5256784

  Copy full SHA for 5256784

Commits on Feb 24, 2022

• Remove addTraceAttributes helper

  

  Josh Holbrook

  committed
  13fa597

  Copy full SHA for 13fa597

• Improve logging

  

  Josh Holbrook

  committed
  0a57ca4

  Copy full SHA for 0a57ca4

• Automatically append service_name and trace_type to every span

  

  Josh Holbrook

  committed
  895db67

  Copy full SHA for 895db67

• Silly templating bug

  

  Josh Holbrook

  committed
  44497db

  Copy full SHA for 44497db

Commits on Feb 25, 2022

• Test that traceExporter respects url

  

  Josh Holbrook

  committed
  c7ed14e

  Copy full SHA for c7ed14e

• Improved otel logging

  

  Josh Holbrook

  committed
  f0d3962

  Copy full SHA for f0d3962

• imports/exports match between honeycomb + prelude

  

  Josh Holbrook

  committed
  c026d6e

  Copy full SHA for c026d6e

• Mock the span in the test instead of as a fallback

  

  Josh Holbrook

  committed
  92a99af

  Copy full SHA for 92a99af

• Fix honeycomb export

  

  Josh Holbrook

  committed
  bea8a01

  Copy full SHA for bea8a01

• Honeycomb logging only generated in debug/dev build

  

  Josh Holbrook

  committed
  cc457bf

  Copy full SHA for cc457bf

• Honeycomb logging fixes

  

  Josh Holbrook

  committed
  1c7ad1d

  Copy full SHA for 1c7ad1d

• Update documentation for OpenTelemetry support

  

  Josh Holbrook

  committed
  876c195

  Copy full SHA for 876c195

• Update examples to use current release build

  

  Josh Holbrook

  committed
  18b8135

  Copy full SHA for 18b8135

• Bump to 0.6.0 and fill out changelog fields

  

  Josh Holbrook

  committed
  421582c

  Copy full SHA for 421582c

• Expand middleware test to cover handlers

  

  Josh Holbrook

  committed
  8687d9f

  Copy full SHA for 8687d9f

• Regenerate all examples

  

  Josh Holbrook

  committed
  82324e5

  Copy full SHA for 82324e5

Commits on Feb 26, 2022

• Respect the same defaults as vanilla beelines

  

  Josh Holbrook

  committed
  b41699d

  Copy full SHA for b41699d

• Don't write debug feature to package.json

  

  Josh Holbrook

  committed
  5cd9d52

  Copy full SHA for 5cd9d52

• Manage node version with volta

  Show description for 485dc3c
  

  Josh Holbrook

  committed
  485dc3c

  Copy full SHA for 485dc3c

Commits on Feb 28, 2022

• Switch from GRPC exporter to HTTP exporter - need to update env vars

  

  Josh Holbrook

  committed
  1d8c127

  Copy full SHA for 1d8c127

• Switch on OTEL_* env vars instead of HONEYCOMB_API_HOST

  

  Josh Holbrook

  committed
  ba5de89

  Copy full SHA for ba5de89

Commits on Mar 1, 2022

• Use otel diagnostic logger

  

  Josh Holbrook

  committed
  04937ca

  Copy full SHA for 04937ca

• Clean up SDK setup, get rid of errors

  

  Josh Holbrook

  committed
  a37f321

  Copy full SHA for a37f321

• Button up otel logging

  

  Josh Holbrook

  committed
  7800566

  Copy full SHA for 7800566

• Remove debug flag from boltzmann generator

  

  Josh Holbrook

  committed
  d4a3e2f

  Copy full SHA for d4a3e2f

• Support ALL THREE OTLP trace exporters

  

  Josh Holbrook

  committed
  91c8183

  Copy full SHA for 91c8183

• Improved comments

  

  Josh Holbrook

  committed
  19bd9e8

  Copy full SHA for 19bd9e8

• More comments

  

  Josh Holbrook

  committed
  5dd398f

  Copy full SHA for 5dd398f

• Only do otel logging if LOG_LEVEL === "debug"

  

  Josh Holbrook

  committed
  b51d8bb

  Copy full SHA for b51d8bb

• Improved comments for OTEL_EXPORTER_OTLP_ENDPOINT

  

  Josh Holbrook

  committed
  5e0756b

  Copy full SHA for 5e0756b

• one OVER sampling rate

  

  Josh Holbrook

  committed
  7314dc5

  Copy full SHA for 7314dc5

• bugfix - use proto exporter when protocol is http/protobuf

  

  Josh Holbrook

  committed
  ca3e9b1

  Copy full SHA for ca3e9b1

• Let otel use the automatically-configured sampler

  

  Josh Holbrook

  committed
  5b030cb

  Copy full SHA for 5b030cb

• Make HONEYCOMB_WRITEKEY optional for otel

  

  Josh Holbrook

  committed
  0c6e45b

  Copy full SHA for 0c6e45b

• Fix volta feature bug

  

  Josh Holbrook

  committed
  0bac3d7

  Copy full SHA for 0bac3d7

• Respect OTEL_SERVICE_NAME

  

  Josh Holbrook

  committed
  3193a9d

  Copy full SHA for 3193a9d

• More tests for parseEnv

  

  Josh Holbrook

  committed
  d8eb480

  Copy full SHA for d8eb480

• Move honeycomb singleton out of prelude

  

  Josh Holbrook

  committed
  d506f52

  Copy full SHA for d506f52

• Don't run honeycomb init inside test block, oops

  

  Josh Holbrook

  committed
  f5dcd9f

  Copy full SHA for f5dcd9f

Commits on Mar 2, 2022

• Rename the default otel http span

  

  Josh Holbrook

  committed
  b34eabf

  Copy full SHA for b34eabf

• Remove comment

  

  Josh Holbrook

  committed
  ca95591

  Copy full SHA for ca95591

• Add span attributes for CORS origin

  

  Josh Holbrook

  committed
  567fe05

  Copy full SHA for 567fe05

Commits on Mar 3, 2022

• Make honeycomb settings logging more useful for beelines

  

  Josh Holbrook

  committed
  08c240f

  Copy full SHA for 08c240f

• Set the initialized flag when beeline

  

  Josh Holbrook

  committed
  301aeac

  Copy full SHA for 301aeac

• Minor logging tweaks

  

  Josh Holbrook

  committed
  b644750

  Copy full SHA for b644750

• Some gaps on beeline trace_type/service.name attributes

  

  Josh Holbrook

  committed
  14eaa9f

  Copy full SHA for 14eaa9f

Commits on Mar 4, 2022

• Rename boltzman.honeycomb.trace_type to honeycomb.trace_type

  

  Josh Holbrook

  committed
  0629cdf

  Copy full SHA for 0629cdf

• Proof-of-concept for closing middleware spans before the next middleware starts

  

  Josh Holbrook

  committed
  27ea1bc

  Copy full SHA for 27ea1bc