Illegal access crash from if-modified-since header #179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node inherits a bug from v8 where some dates raise exceptions instead of returning an
Invalid Date
object:Knowing this, it's possible to crash ecstatic by sending a malicious
If-Modified-Since
header:This patch guards the
Date
instance with a try/catch to prevent these v8 bugs from bringing down ecstatic.