Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Skip comment generation on PR success if needed #809

Merged
merged 5 commits into from
Dec 29, 2024
Merged

Skip comment generation on PR success if needed #809

merged 5 commits into from
Dec 29, 2024

Conversation

eyalk007
Copy link
Contributor

@eyalk007 eyalk007 commented Dec 29, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Update documentation about new features / new supported technologies

Look at this pr for reference: #778

Add option to skip generating success comment (no issues), you can enable this option by:

using JF_PR_ADD_SUCCESS_COMMENT=false
adding addPrCommentOnSuccess: false to the config

@eyalk007 eyalk007 added the improvement Automatically generated release notes label Dec 29, 2024
@eyalk007 eyalk007 added the safe to test Approve running integration tests on a pull request label Dec 29, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 29, 2024
@eyalk007 eyalk007 added the safe to test Approve running integration tests on a pull request label Dec 29, 2024
@eyalk007 eyalk007 self-assigned this Dec 29, 2024
@eyalk007 eyalk007 requested a review from attiasas December 29, 2024 11:59
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 29, 2024
@eyalk007 eyalk007 added the safe to test Approve running integration tests on a pull request label Dec 29, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 29, 2024
@eyalk007 eyalk007 linked an issue Dec 29, 2024 that may be closed by this pull request
Resolving Pull request comment from frogbot #775
Closed
@eyalk007 eyalk007 added the safe to test Approve running integration tests on a pull request label Dec 29, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.

attiasas
attiasas approved these changes Dec 29, 2024
View reviewed changes
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eyalk007 eyalk007 merged commit b70fc31 into jfrog:dev Dec 29, 2024
33 checks passed
@attiasas attiasas added new feature Automatically generated release notes and removed improvement Automatically generated release notes labels Jan 7, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@attiasas attiasas attiasas approved these changes

Assignees

@eyalk007 eyalk007

Labels
new feature Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolving Pull request comment from frogbot
2 participants
@eyalk007 @attiasas