This repository has been archived by the owner on Aug 4, 2022. It is now read-only.
Add benchmark-Script #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new Configuration Variable 'REPLACE_REGISTRY_URL'. This this Variable a User can decide if he want that the the "Target" Docker Registry Domain (eg. 'quay.io') will be replaced with this own Domain, or if this Registry Domain will be simply pre-pendeted. Example: Kubelet pulls Image: 'docker.io/library/nginx:latest' With 'REPLACE_..' Enabled: 'jfrog.local/library/nginx:latest' With 'REPLACE_..' Disabled: 'jfrog.local/docker.io/library/nginx:latest' This is because we at FABMation are "sorting" the Images from 3rd-Party Registries (and sign them). So having the possibility to decide if the original Registry Domain should be replaced or not is a nice Feature. Signed-off-by: Emanuel Bennici <benniciemanuel78@gmail.com>
Add a Function that checks if all required Flags are set and in a Correct Format (eg. bool). Signed-off-by: Emanuel Bennici <benniciemanuel78@gmail.com>
Signed-off-by: Emanuel Bennici <benniciemanuel78@gmail.com>
Implement the Functionality of the 'REPLACE_REGISTRY_URL' Configuration/ Environment Variable to let the User decide if he wants to pre-pend this Docker Registry Domain or replace the "old" one. Signed-off-by: Emanuel Bennici <benniciemanuel78@gmail.com>
Add the new 'REPLACE_REGISTRY_URL' Configration Environment Variable to the Kubernetes Deployment. Signed-off-by: Emanuel Bennici <benniciemanuel78@gmail.com>
Add a new Helm Value 'docker.replaceRegistryUrl' to use/ configure the 'REPLACE_REGISTRY_URL' Environment Variable. Signed-off-by: Emanuel Bennici <benniciemanuel78@gmail.com>
Add in-line Documentation in _values.yaml_ about the the 'docker.replaceRegistryUrl' Value does. Close #7 Signed-off-by: Emanuel Bennici <benniciemanuel78@gmail.com>
Fix the wrong usage of a String. Convert string to Bool and ignoring returing Errors because this is already checked at the begining of the Application. Signed-off-by: Emanuel Bennici <benniciemanuel78@gmail.com>
In the 'benchmark/' Directory is a Script called `benchmark.sh`, this Script uses _docker_ and bombardier[^1] to "simulate" a K8s-Cluster on which a hug amount of new Pods/ Containers are getting created. The `*_body` are containing the Request Body of a "Real-World" K8s-Cluster. [^1]: https://github.com/codesenberg/bombardier Signed-off-by: Emanuel Bennici <benniciemanuel78@gmail.com>
Signed-off-by: Emanuel Bennici <benniciemanuel78@gmail.com>
Add Benchmark Results generated on an Laptop with the following Specs: - Intel(R) Core(TM) i5-3230M CPU @ 2.60GHz || 2/4 Cores/Threads - 8 RAM - Swapping off - Linux kernel: `4.18.0-25-generic` Closes #9 Signed-off-by: Emanuel Bennici <benniciemanuel78@gmail.com>
|
thanks for this PR as well 👍 |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a Benchmark-Script to compare the speed of the Application after changes made to the Code.
Closes #9