Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix usage system parameters #243

Merged
merged 22 commits into from
Jan 6, 2025

Conversation

EyalDelarea
Copy link
Contributor

@EyalDelarea EyalDelarea commented Jan 5, 2025

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used npm run format for formatting the code before submitting the pull request.

This pull request align the job_id mismatch between workflow name and job_id.

And also, encoded the workflow name to handle possible spaces in the filename

@EyalDelarea EyalDelarea added the bug Something isn't working label Jan 5, 2025
@EyalDelarea EyalDelarea requested a review from RobiNino January 5, 2025 10:22
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Jan 5, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 5, 2025
src/utils.ts Outdated Show resolved Hide resolved
src/utils.ts Outdated Show resolved Hide resolved
@EyalDelarea EyalDelarea changed the title Align usage paramters Fix usage system parameters Jan 5, 2025
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Jan 6, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 6, 2025
lib/utils.js Outdated Show resolved Hide resolved
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Jan 6, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 6, 2025
Copy link

github-actions bot commented Jan 6, 2025

👍 Frogbot scanned this pull request and did not find any new security issues.


@EyalDelarea EyalDelarea merged commit 1a51b15 into jfrog:master Jan 6, 2025
21 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants