Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Several examples parsed incorrectly #31

Closed
keskival opened this issue Dec 14, 2017 · 4 comments
Closed

Several examples parsed incorrectly #31

keskival opened this issue Dec 14, 2017 · 4 comments

Comments

@keskival
Copy link

#30

console.log(urljoin('http://example.org', 'a//', 'b//', 'A//', 'B//'))
// -> 'http://example.org/a/b/A//B/'

console.log(urljoin('http://example.org/x', '?a=1', '?b=2', '?c=3', '?d=4'))
// -> http://example.org/x?a=1?b=2?c=3&d=4

console.log(urljoin('http://example.org/', ':foo:', 'bar'))
// -> http://example.org/:foo://bar

@jfromaniello
Copy link
Owner

#30 is merged, let me know if we can close this

@keskival
Copy link
Author

@jfromaniello : New PR which fixes this and the newly discovered issue: #35

Once that is merged, then we can close this.

@keskival
Copy link
Author

And this is now otherwise good, but the package needs to be published to the npm registry, @jfromaniello .
https://www.npmjs.com/package/url-join

@jfromaniello
Copy link
Owner

@keskival sorry about that! just published v3 to npm

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants