Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixed the protocol-part issue, merged upstream. #35

Merged
merged 2 commits into from
Jan 12, 2018

Conversation

keskival
Copy link

This is basically this PR fixed considering the regression issue:
#30

Relates to #30 and #34 .

@jfromaniello jfromaniello merged commit 45820c7 into jfromaniello:master Jan 12, 2018
@jfromaniello
Copy link
Owner

Thanks a lot for the work!

This time I published as v3.0.0 just in case we break some other use case for which we might not have a test yet.

Thanks again!

@keskival
Copy link
Author

@jfromaniello : Thanks to you! Can you publish the new version to the npm registry also?
https://www.npmjs.com/package/url-join

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants