Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

Commit

Permalink
Fix Test log inputs with large inputs limit check (#47)
Browse files Browse the repository at this point in the history
* WIP, return nil for empty strings

Signed-off-by: nojaf <florian.verdonck@outlook.com>

* Add some more logging

Signed-off-by: nojaf <florian.verdonck@outlook.com>

* Use fork as ref

Signed-off-by: nojaf <florian.verdonck@outlook.com>

* Revert temp changes

Signed-off-by: nojaf <florian.verdonck@outlook.com>

* Revert python change

Signed-off-by: nojaf <florian.verdonck@outlook.com>

* Revert mlflow ref to master

Signed-off-by: nojaf <florian.verdonck@outlook.com>

* Remove failing test workaround

Signed-off-by: nojaf <florian.verdonck@outlook.com>

* Continue when windows

Signed-off-by: nojaf <florian.verdonck@outlook.com>

* Only on Ubuntu then?

Signed-off-by: nojaf <florian.verdonck@outlook.com>

---------

Signed-off-by: nojaf <florian.verdonck@outlook.com>
  • Loading branch information
nojaf authored Oct 1, 2024
1 parent 15501c5 commit e522f8e
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,4 +56,4 @@ jobs:
- name: Run integration tests
run: mage test:python
# Temporary workaround for failing tests
continue-on-error: true
continue-on-error: ${{ matrix.runner != 'ubuntu-latest' }}
18 changes: 15 additions & 3 deletions pkg/entities/dataset.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package entities

import "github.com/mlflow/mlflow-go/pkg/protos"
import (
"github.com/mlflow/mlflow-go/pkg/protos"
)

type Dataset struct {
Name string
Expand All @@ -12,12 +14,22 @@ type Dataset struct {
}

func (d *Dataset) ToProto() *protos.Dataset {
var schema *string
if d.Schema != "" {
schema = &d.Schema
}

var profile *string
if d.Profile != "" {
profile = &d.Profile
}

return &protos.Dataset{
Name: &d.Name,
Digest: &d.Digest,
SourceType: &d.SourceType,
Source: &d.Source,
Schema: &d.Schema,
Profile: &d.Profile,
Schema: schema,
Profile: profile,
}
}

0 comments on commit e522f8e

Please # to comment.