-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Allow option flags to accept False value #8788
Comments
This would require small changes in file |
Thanks for the analysis! I could see to propose a PR, but I'm not at ease with Haskell; do I need to set up a Haskell environment for this update? Or is a simple file update, and the CI will do its job properly? |
I'd suggest to setup a local Haskell env to enable proper testing. It might be possible to do this only with the CI, but I'd expect it to be a slightly frustrating experience.
|
Hello everyone, I've taken the initiative to create a pull request that addresses OP's request. Please feel free to take a look at it. |
Default is true if no value is specified, so this is fully backwards-compatible. Closes #8788.
Hi @samahri thanks for the implementation!! My Haskell level would have been really too low to achieve your improvements. Now I'm looking forward to the release to production :) |
Glad I could help! |
Context
I have a project where
pandoc
is used to generate a Reveal.JS presentation, and this project aims to be a presentation generator.In order to allow for offline usage and proper archival, I use the
--embed-resources --standalone
option flags, and I want this to be the default behavior so I set them in the defaults parameters file.Observed Problem
During writing, it is much faster not to embedd the resources. But my defaults file activates the
--embed-resources
, and there is no way to overload the flag for deactivation. Providing--embed-resources=false
is refused.For the moment, I therefore deactivated the
embed-resources
in the defaults file, but shall take care to activate it in the rendering pipeline.Proposal
Allow for overloading the
embed-resources
option from defaults with a command-line value requesting no embedding.In #8362, in particular with one answer, there is a proposal to extend accepted values for
--embed-resources
flag withnone
value: this would be perfect.The text was updated successfully, but these errors were encountered: