Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Missplaced ) in Windows output #14

Closed
OrangeDog opened this issue Oct 27, 2016 · 2 comments
Closed

Missplaced ) in Windows output #14

OrangeDog opened this issue Oct 27, 2016 · 2 comments
Labels
Milestone

Comments

@OrangeDog
Copy link

Split from #13

> pip-review
)raintree==3.30.0 is available (you have 3.27.0
)assandra-driver==3.7.1 is available (you have 2.7.1
)ffi==1.8.3 is available (you have 1.3.1
)ryptography==1.5.2 is available (you have 1.1.1
)ssselect==1.0.0 is available (you have 0.9.1

pip-review 0.5
Consistent across multiple versions of Windows 10.
Same issue in Command Prompt, PowerShell and mintty.

> python
Python 2.7.12 (v2.7.12:d33e0cf91556, Jun 27 2016, 15:19:22) [MSC v.1500 32 bit (Intel)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import locale
>>> locale.getlocale()
(None, None)
>>> locale.getdefaultlocale()
('en_GB', 'cp1252')
@OrangeDog
Copy link
Author

My guess is that a previous parse only looked for \n instead of the platform line endings.
We see here that there is an extra \r at the end of the current version number.

> pip-review | xxd
00000000: 6272 6169 6e74 7265 653d 3d33 2e33 302e  braintree==3.30.
00000010: 3020 6973 2061 7661 696c 6162 6c65 2028  0 is available (
00000020: 796f 7520 6861 7665 2033 2e32 372e 300d  you have 3.27.0.
00000030: 290d 0a63 6173 7361 6e64 7261 2d64 7269  )..cassandra-dri

@jgonggrijp
Copy link
Owner

Good research, thanks for reporting!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants