-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
build(css): build minified bundle #643
Conversation
adds a minfied css bundle and uses it closes #642
@jgthms here's why you should do this:
I tested the docs site without autoprefixer and everything looks good. The argument we shouldn't be minifying because there were problems before seems moot, as the same argument could be made for autoprefixing as well. Please give it a whirl and let me know how it goes with autoprefixer. |
Nice work! 👍 I reckon it would be useful to keep both |
@jgthms I'll do another sweep at this now that I've gotten an approval sign. Will ensure everyone gets what they want, and will look to add source maps if it makes sense (otherwise open another issue if needed). |
@jgthms Took another pass. Don't see any more work to do. Please let me know if you need anything else to make this merge-friendly. Thanks! |
@jgthms some individuals would like this merged. care to do us the honors if you're comfortable with the changes? |
Is this gonna be merged or not? My Bulma production build is 860++KB right now and I think this will decrease the size tremendously @jgthms |
@1zaak I'll leave it to the maintainers to answer that. There's a conflict caused by an addition of css asset fingerprinting which, when I see, is usually a sign of overengineering in the App tier. |
adds a minfied css bundle and uses it
closes #642