Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

build(css): build minified bundle #643

Closed
wants to merge 1 commit into from
Closed

build(css): build minified bundle #643

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 5, 2017

adds a minfied css bundle and uses it

closes #642

adds a minfied css bundle and uses it

closes #642
@ghost
Copy link
Author

ghost commented Apr 5, 2017

@jgthms here's why you should do this:

  • prevents duplicative work after download, helping ensure bulma sites in the wild always looks like the docs site (helps prevent mangling of css by limiting need to do so)
  • increases page speed of the docs site

I tested the docs site without autoprefixer and everything looks good. The argument we shouldn't be minifying because there were problems before seems moot, as the same argument could be made for autoprefixing as well. Please give it a whirl and let me know how it goes with autoprefixer.

@jgthms
Copy link
Owner

jgthms commented Apr 12, 2017

Nice work! 👍

I reckon it would be useful to keep both bulma.css and bulma.min.css. Some people might want the non-minified version as it's easier to read, if they want to copy some code, or get inspiration, which is easier than navigating through the .sass files.

@ghost
Copy link
Author

ghost commented Apr 12, 2017

@jgthms I'll do another sweep at this now that I've gotten an approval sign. Will ensure everyone gets what they want, and will look to add source maps if it makes sense (otherwise open another issue if needed).

@ghost
Copy link
Author

ghost commented Apr 25, 2017

@jgthms Took another pass. Don't see any more work to do. Please let me know if you need anything else to make this merge-friendly. Thanks!

@ghost
Copy link
Author

ghost commented May 26, 2017

@jgthms some individuals would like this merged. care to do us the honors if you're comfortable with the changes?

@jgthms jgthms self-requested a review May 28, 2017 13:01
@jgthms jgthms self-assigned this May 28, 2017
@jgthms jgthms removed their request for review May 28, 2017 13:01
@1zaak
Copy link

1zaak commented Dec 24, 2017

Is this gonna be merged or not? My Bulma production build is 860++KB right now and I think this will decrease the size tremendously @jgthms

@ghost
Copy link
Author

ghost commented Dec 27, 2017

@1zaak I'll leave it to the maintainers to answer that. There's a conflict caused by an addition of css asset fingerprinting which, when I see, is usually a sign of overengineering in the App tier.

@1zaak
Copy link

1zaak commented Dec 27, 2017

Sorry I should correct this, it was my own mistake of importing a huge font sass file. Not the maintainers fault @JHabdas. I closed this ticket #1560

@ghost ghost mentioned this pull request Dec 27, 2017
@jgthms jgthms closed this Apr 8, 2018
@ghost ghost deleted the build-minified branch June 15, 2018 12:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ship Minified to Packagers
2 participants