-
-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Upgrade remotedev-app to v0.8 & New features #16
Conversation
@@ -13,6 +13,9 @@ | |||
width: 100%; | |||
background-color: rgb(53, 59, 70); | |||
} | |||
* { | |||
outline: none; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha, agree that the outline around the slider monitor looks ugly, but it's for accessibility reason, so you can move between buttons and slider by pressing Tab. Otherwise you don't know what element is selected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zalmoxisus Ah, sounds good to me, I'll revert it. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can enhance rebass slider so it will have an outline only for the circle like material-ui does.
Of course we could juse use Material-UI slider and I tried it, but found rebass' themes better to extend and in future even to add a material design theme there as an option. So, we'll switch all the components to rebass.
2f6db65
to
2e1c246
Compare
baff6fa
to
6a1e621
Compare
@zalmoxisus, I think we can have a |
@jhen0409, Why not just to use Checking As a side note. The idea of Of course, those are more just ideas, there's still a lot of work in order to make that possible, and I was stuck making the extension performant and reliable. Also thanks for your help! Maybe we could raise also some support for our work :) |
Actually I'm ready to add it, this way we can directly use npm package of
This is great idea, so recently I'm planing to use redux-remotedev in my team, this is why I made docker-remotedev-server, although it's still not really being used.. Also, currently the updates of
Thanks @zalmoxisus! I'll continue to support it, because it's really useful for improve my development experience. :) |
It should work already if you use |
remotedev-app v0.8 have big refactor from v0.7, now we can better integrate into the RNDebugger.
New
remotedev-app
featuresNew
reduxNativeDevToolsCompose
Refer to redux-devtools-extension, we provide a new way instead of
reduxNativeDevTools
andreduxNativeDevTools.updateStore
:Multi-store support
Now we can use
reduxNativeDevTools
for each store, and we can switch instances on monitor: