feat: add frame rate option for startSession

jhen0409 · Mar 2, 2020 · acd1e48 · acd1e48
1 parent bf1abc5
commit acd1e48
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/packages/react-native-webrtc-ar-session/index.ios.js b/packages/react-native-webrtc-ar-session/index.ios.js
@@ -13,9 +13,9 @@ const checkNativeModule = () =>
     'Native Module `react-native-webrtc-ar-session` is not linked.',
   )
 
-export const startCapturingARView = () => {
+export const startCapturingARView = (options = {}) => {
   checkNativeModule()
-  return RNWebRTCARSession.startSession()
+  return RNWebRTCARSession.startSession(options)
 }
 
 export const stopCapturingARView = () => {

diff --git a/packages/react-native-webrtc-ar-session/ios/RNWebRTCARSession.m b/packages/react-native-webrtc-ar-session/ios/RNWebRTCARSession.m
@@ -159,7 +159,12 @@ - (void)captureARSnapshot API_AVAILABLE(ios(11.0)){
   resolve(@{});
 }
 
-RCT_EXPORT_METHOD(startSession:(RCTPromiseResolveBlock)resolve reject:(RCTPromiseRejectBlock)reject) {
+RCT_EXPORT_METHOD(startSession:(NSDictionary *)options
+  resolve:(RCTPromiseResolveBlock)resolve
+  reject:(RCTPromiseRejectBlock)reject
+) {
+  NSInteger frameRate = [options[@"frameRate"] intValue];
+
   if (@available(iOS 11.0, *)) {
     _videoSource = [WebRTCModule arVideoSource];
 
@@ -174,10 +179,13 @@ - (void)captureARSnapshot API_AVAILABLE(ios(11.0)){
       dispatch_queue_t queue = dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0);
       self.timer = dispatch_source_create(DISPATCH_SOURCE_TYPE_TIMER, 0, 0, queue);
 
+      if (!frameRate) {
+        frameRate = _arView.preferredFramesPerSecond;
+      }
       dispatch_source_set_timer(
         self.timer,
         DISPATCH_TIME_NOW,
-        NSEC_PER_SEC / _arView.preferredFramesPerSecond,
+        NSEC_PER_SEC / frameRate,
         NSEC_PER_SEC
       );