Skip to content

Commit

Permalink
Don't build dev images on git tags, tag im with latest-itb and sha256
Browse files Browse the repository at this point in the history
The previous action had a side effect such that whenever someone created a new
tag for some release/release candidate, a new container with latest-itb would
get pushed to Harbor, but from the `dev.Dockerfile` as it exists for that tag.

This essentially means _some_ but not all latest-itb tags weren't actually
tracking main, but other branches instead.

After a chat with Sarthak & Emma, we don't see much use in building dev
containers that aren't produced from the main branch, since we don't do dev
work like that on our release series branches.

This commit removes tags as a trigger from the workflow, and only uses
the image's sha256 and latest-itb as tags
  • Loading branch information
jhiemstrawisc committed Jan 27, 2025
1 parent 34d1c48 commit a054a86
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions .github/workflows/build-dev-container.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@ name: Build and Push Dev Image
on:
pull_request:
push:
tags:
# only build and publish container on v7.0.0 and up
- v[7-9]\.[0-9]+\.[0-9]+-**
- v[1-9][0-9]+\.[0-9]+\.[0-9]+-**
branches:
- main

Expand All @@ -24,9 +20,7 @@ jobs:
with:
images: hub.opensciencegrid.org/pelican_platform/pelican-dev
tags: |
type=semver,pattern={{version}}
type=raw,value=latest-itb
type=ref,enable=true,prefix=itb-,suffix=-{{date 'YYYYMMDDHHmmss'}},event=tag
type=raw,value=sha-{{sha}}
- name: Set up Docker Buildx
Expand Down

0 comments on commit a054a86

Please # to comment.