Fix translation issue where an interpolation param contains a ReactEl… #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ement that is merged into a translation string containing HTML. Fix translation issue where an interpolation param contains a ReactElement that is merged into a translation string containing HTML.
qmonmert
approved these changes
May 13, 2023
1 task
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue with the translation where a param that is a ReactElement is interpolated into a translation string containing HTML.
language.json
{ "sample": { "title": "This demonstrates the <br /> {{ issue }}" } }component.tsx
translate('sample.title', { issue: <div>Will not be shown</div> })result
This demonstrates the
[object Object]
If the translation string does not contain html (
<br />) the interpolation of thedivparam works.