adding intersection of require calls #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your detailed PR (with tests and docs 👍). I'm definitely willing to merge this as it was already requested several times ( #24 #44 #68 ). One problem I see, though, is that it needs to be implemented for rewire-webpack as well. I would like users to be able to use rewire features also with webpack without needing to care about which feature is supported. I need some time to implement it ... |
airhorns
added a commit
to airhorns/rewire
that referenced
this pull request
Jun 25, 2021
airhorns
added a commit
to airhorns/rewire
that referenced
this pull request
Jun 29, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes should allow intersection of require calls in the module. The require function gets substituted with one that delegates calls to either a custom function, or one that uses an object as a path ->module map.
I have included some test code, and a line in the readme talking about the feature.