-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Adds format-filepath
to customize the filepath of .clang-format
#211
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Could you add some test coverage in test/
? I think it should be enough to move .clang-format
in that directory to a nested directory and pass its new path to this arg that you've added to the shellscript invocation in test.sh
.
Should be ready. I needed to rename the format file not |
Wow big oversight on my part. The syntax I am using for clang-format style=file: was added in clang 14. I guess there is not much that could be done here short of making the use of the file option conditional and adding a note in the documentation? I pushed a fix to the CI for the clang 14+ failures. |
Hey guys, how is this change progressing? This is something we are looking forward to. It would be great if we could get these changes integrated. |
Hey - is this PR still being worked on? |
Clang format before v14 does not have the filepath setting. Therefore in order to have passing CI behavior and correct operation on lower versions, I must re-arrange the way we test the format filepath setting. Ill work on that in the next week or two. |
@jidicula I may be backwards here, however I am very confused as to how the current CI detects the |
See title.
This allows any file with valid clang format contents to be specified as the filepath.
In my organization this allows a submodule common across multiple C repositories to contain the
clang-format
, so an update of the submodule updates the styling across the org.Closes #156