Fix BooleanColumn with choices set will always render as if True #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Aside from being ugly, this also doesn't work if the column uses a custom accessor :( |
jieter
force-pushed
the
onnokort-master
branch
2 times, most recently
from
b110ec3 to
bb07c80
Compare
jieter
changed the title
jieter
force-pushed
the
onnokort-master
branch
4 times, most recently
from
293534d to
d9f6f9d
Compare
jieter
force-pushed
the
onnokort-master
branch
from
323c434 to
066a02f
Compare
|
The current implementation should be more complete. Please tell me what you think @onnokort. |
|
Code looks good. Let me try to backport these fixes and see whether my application does the right thing with them. Will get back to you on this. Oh, and thank you for this nice software! |
|
@onnokort thanks. Just noticed that |
jieter
force-pushed
the
onnokort-master
branch
from
066a02f to
65fc7aa
Compare
|
This version looks even better. |
jieter
force-pushed
the
onnokort-master
branch
2 times, most recently
from
b88939f to
5250177
Compare
Adds test_boolean_field_choices_with_real_model_instances() to tests/columns/test_booleancolumn.py. After a wild-goose chase suspecting Django localization (which was apparently not the problem), this is a test case that will fail for a BooleanColumn representing a model.BooleanField with a choices=... parameter set. The reason that this test fails seems to be somewhere in the code path that handles real model data. The test will pass when just using a pair of mock-up dictionaries. The test will also pass when removing the choices=... parameter from the field = models.BooleanField(...) declaration.
- by using code previously used in BoundColumn.verbose_name - also make BoundColumn.verbose_name use the new implemenation
jieter
force-pushed
the
onnokort-master
branch
from
5250177 to
7a53aec
Compare
|
@onnokort any news? |
jieter
added a commit
that referenced
this pull request
Feb 9, 2016
Fix BooleanColumn with choices set will always render as if True
jieter
added a commit
that referenced
this pull request
Feb 9, 2016
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #300, #290
This implements a fix for the failing tests as proposed by @onnokort. It's not really pretty though. What do you think @onnokort?
Also includes the test from #300.
TODO
Accessor.get_field()inBoundColumn.verbose_name.