Add context arguments to TemplateColumn

[ad-m]

Hello,

I suggest add argument to TemplateColumn. This is important to ensure effective re-use of templates as in following example.

Example template:

{% load i18n %}
<div class="btn-group" role="group" aria-label="{{ record }} actions">
    <a href="{% url update_viewname pk=record.pk %}" class="btn btn-success">
        {% trans 'Update' %}
    </a>
    <a href="{% url delete_viewname pk=record.pk %}" class="btn btn-danger">
        {% trans 'Delete' %}
    </a>
</div>

Example table:

class PhoneNumberTable(tables.Table):
    action = TemplateColumn(template_name='auth_factories/_default/_action_table.html',
                            context={'update_viewname': 'auth_factories:sms_code:update',
                                     'delete_viewname': 'auth_factories:sms_code:delete'})

    class Meta:
        model = PhoneNumber
        template = 'django_tables2/bootstrap-responsive.html'
        fields = ('phone', 'last_used',)

[jieter]

@ad-m Nice idea, could be very useful!

At first thought I'd suggest renaming the context argument to extra_context, because naming it context implies that that'll replace the context passed to the template. Did you consider this? What do you think?

[ad-m]

@jieter , you are right. Fix'd.

[jieter]

Thanks for the change. I've added some other comments, will merge when those are addressed.

[jieter]

This sentence seems to be incomplete.

[ad-m]

@jieter , Can you suggest a full content of line? I do not know enough English to do it myself.

[jieter]

What about:

extra_content (dict): optional extra template context.

[jieter]

this one too. Also: please use the same style as the other list items.

[ad-m]

I changed the style because the keys are listed before, and here the value of the context key is dynamic. No static keys of context, so no bold.

[jieter]

ah, makes sense! I would propose:

 - any context variables passed using the `extra_context` argument to `TemplateColumn`.

[jieter]

can you add spaces around label to get consistent style with the other template variables in the example?

[ad-m]

@jieter , changes introduced. Thank you for your comments and help.

[jieter]

@ad-m thanks for the changes.

As the final piece of the puzzle, It would be nice if you could add a test case checking for the extra context to be present.

[jieter]

@ad-m thanks, merged!