Fix critical regression bug with AR_thr and threshold

jimmielin · Apr 19, 2022 · 8b31bfb · 8b31bfb
1 parent 9dcca08
commit 8b31bfb
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/KPP/fullchem/gckpp_Integrator.F90 b/KPP/fullchem/gckpp_Integrator.F90
@@ -878,7 +878,7 @@ SUBROUTINE ros_yIntegrator (Y, Tstart, Tend, T,  &
        DO i=1,NVAR
          ! Short-circuiting using SKIP is very important here.
          if (.not. keepSpcActive(i) .and. &
-             abs(LossY(i)).lt.threshold .and. abs(Prod(i)).lt.threshold) then ! per Shen et al., 2020
+             abs(LossY(i)).lt.AR_thr .and. abs(Prod(i)).lt.AR_thr) then ! per Shen et al., 2020
             NRMV=NRMV+1
             ! RMV(NRMV) = i ! not needed unless in append version.
             DO_SLV(i) = .false.
@@ -894,7 +894,7 @@ SUBROUTINE ros_yIntegrator (Y, Tstart, Tend, T,  &
       IF (.not. keepActive) THEN
         DO i=1,NVAR
          ! Short-circuiting using SKIP is very important here.
-         if (abs(LossY(i)).lt.threshold .and. abs(Prod(i)).lt.threshold) then ! per Shen et al., 2020
+         if (abs(LossY(i)).lt.AR_thr .and. abs(Prod(i)).lt.AR_thr) then ! per Shen et al., 2020
             NRMV=NRMV+1
             ! RMV(NRMV) = i ! not needed unless in append version.
             DO_SLV(i) = .false.
@@ -1329,7 +1329,7 @@ SUBROUTINE ros_yIntegratorA (Y, Tstart, Tend, T,  &
        DO i=1,NVAR
          ! Short-circuiting using SKIP is very important here.
          if (.not. keepSpcActive(i) .and. &
-             abs(LossY(i)).lt.threshold .and. abs(Prod(i)).lt.threshold) then ! per Shen et al., 2020
+             abs(LossY(i)).lt.AR_thr .and. abs(Prod(i)).lt.AR_thr) then ! per Shen et al., 2020
             NRMV=NRMV+1
             RMV(NRMV) = i
             DO_SLV(i) = .false.
@@ -1345,7 +1345,7 @@ SUBROUTINE ros_yIntegratorA (Y, Tstart, Tend, T,  &
       IF (.not. keepActive) THEN
         DO i=1,NVAR
          ! Short-circuiting using SKIP is very important here.
-         if (abs(LossY(i)).lt.threshold .and. abs(Prod(i)).lt.threshold) then ! per Shen et al., 2020
+         if (abs(LossY(i)).lt.AR_thr .and. abs(Prod(i)).lt.AR_thr) then ! per Shen et al., 2020
             NRMV=NRMV+1
             RMV(NRMV) = i
             DO_SLV(i) = .false.