Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make IdentityPlan! subtype AbstractCustomPlan #46

Merged
merged 2 commits into from
May 7, 2022

Conversation

glwagner
Copy link
Contributor

@glwagner glwagner commented May 7, 2022

Should close #45

@glwagner
Copy link
Contributor Author

glwagner commented May 7, 2022

Perhaps we should add a test for NoTransform!?

@jipolanco
Copy link
Owner

Thanks for catching that! Yeah, I'll add a test for this.

@codecov
Copy link

codecov bot commented May 7, 2022

Codecov Report

Merging #46 (9cc0a64) into master (4e0cdfe) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #46   +/-   ##
=======================================
  Coverage   98.32%   98.32%           
=======================================
  Files           9        9           
  Lines         419      419           
=======================================
  Hits          412      412           
  Misses          7        7           
Impacted Files Coverage Δ
src/Transforms/no_transform.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e0cdfe...9cc0a64. Read the comment docs.

@jipolanco jipolanco merged commit fc7782e into jipolanco:master May 7, 2022
@glwagner glwagner deleted the patch-1 branch May 7, 2022 21:08
glwagner added a commit to glwagner/PencilFFTs.jl that referenced this pull request May 8, 2022
To capture jipolanco#46 for Oceananigans 🙇‍♂️
@glwagner glwagner mentioned this pull request May 8, 2022
jipolanco pushed a commit that referenced this pull request May 8, 2022
To capture #46 for Oceananigans 🙇‍♂️
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error making plan with NoTransform!()
2 participants