New commands (including sync with file, validity management…) #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
as promised in #39 here is a PR containing many changes.
I have some comments about these changes (in addition to the ones already discussed in #39):
_decode_all
, as I'm not sure it's the right way to do it (first time I deal with decoding).or pattern == '*'
condition, certainly the best approach if we want to keep it simple.add
command now accepts more than one key in the file.add
command, I added the--update
option which updates the expiration date of the keys if they are already existing.sync_pubkeys
. I useprint
in this function, which is not a thing we want in__init__.py
. But on the other hand, I have to print near private methods… Maybe should I append the output to a variable and return this variable, but it's not really good either, because some output could be missed in the case of an error raise. I'll take any good idea for this, I guess I'll have to refactor this method.--help
containing all the options. As a user, I really prefer when there are specific helps for each command, containing just the appropriate options. But on the other hand, doing this means the tool is now a bit more complex than before…