-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix: Upgrade Kinobi to Codama #39
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The upgrade looks good to me, but what is the purpose?
if we upgrade to to codama, we can have some merits. One thing that we can specify the trait of struct. I think this is useful. const traitOptions = {
baseDefaults: [
'borsh::BorshSerialize',
'borsh::BorshDeserialize',
'serde::Serialize',
'serde::Deserialize',
'Clone',
'Debug',
'Eq',
'PartialEq',
],
dataEnumDefaults: [],
scalarEnumDefaults: ['Copy', 'Hash', 'num_derive::FromPrimitive', 'clap::ValueEnum'],
structDefaults: [],
};
weightTableKinobi.accept(renderers.renderRustVisitor(path.join(rustWeightTableClientDir, "src", "generated"), {
formatCode: true,
crateFolder: rustWeightTableClientDir,
deleteFolderBeforeRendering: true,
toolchain: "+nightly-2024-07-25",
traitOptions,
})); |
I appreciate your work here, however, I'm hesitant to introduce anything new here. So I'm closing - if it's not broke, dont fix it Again, thank you for the work here |
NVM, upon further review, we'll merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this is gonna break after jito-foundation/restaking#203 is merged, can hold off on addressing it until we have a good plan
Kinobi renamed to Codama.
This PR upgrades to Codama, one of the merit is that we can specify traitOption.