AV moderation and muting improvements #15628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damencho
force-pushed
the
moderation-and-muting
branch
from
5ad4cf4 to
a4bac9f
Compare
saghul
reviewed
Feb 19, 2025
| dispatch(playSound(ASKED_TO_UNMUTE_SOUND_ID)); | ||
| // hide any existing notification as we will show a new one | ||
| // the case where first audio is approved and then video is approved, we avoid double notification | ||
| dispatch(hideNotification(ASKED_TO_UNMUTE_NOTIFICATION_ID)); |
There was a problem hiding this comment.
No need to hide it if you are just about to push a new one. If it has the same ID it will replace it.
damencho
force-pushed
the
moderation-and-muting
branch
2 times, most recently
from
56b77df to
832f73b
Compare
| @@ -11,7 +11,7 @@ import { shouldShowModeratedNotification } from '../av-moderation/functions'; | |||
| import { setAudioMuted, setVideoMuted } from '../base/media/actions'; | |||
| import { MEDIA_TYPE, MediaType, VIDEO_MUTISM_AUTHORITY } from '../base/media/constants'; | |||
| import { muteRemoteParticipant } from '../base/participants/actions'; | |||
| import { getLocalParticipant, getRemoteParticipants } from '../base/participants/functions'; | |||
| import { getRemoteParticipants } from '../base/participants/functions'; | |||
There was a problem hiding this comment.
I don't see why do we need this change?
There was a problem hiding this comment.
Ups, that needs to be in the first commit. "fix(video-menu): When muting all skip local."
I can move it.
There was a problem hiding this comment.
it was failing lint and I put it in the wrong commit.
When muting multiple participants always skip the local one for audio and for video.
When both audio and video is to be allowed, make the audio the first one to show nad video to stay in the 3-dots menu.
We were showing only one option in the notification that was allowing both at the same time. We add not 3 option, allow audio, allow video or both.
…on sticky. If the notification disappears, we don't have any other indication about this. We were not showing any notification if only video is allowed. Adds option to unmute audio or video, depend on what was allowed.
damencho
force-pushed
the
moderation-and-muting
branch
from
832f73b to
e950ca0
Compare
hristoterezov
approved these changes
Feb 20, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.