Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(poll): structure #15645

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

joshuai96
Copy link
Contributor

When using a screen reader the polls are not easily perceivable.

This is related to WCAG Success Criterion 1.3.1 Info and Relationships.

  • Checkbox changes:
    The checkbox component now uses a given id, the name or a random id to link it's input to the label. This further optimizes the perception with assistive technologies.
  • Packages update:
    The type packages missed the last update and using the useId hook failed linting.
  • Poll:
    The question and answers were not grouped together logically enough for assistive technologies like a screen reader. Wrapping in a fieldset with a legend binds them together better instead of the ul element. The poll result is logically still an unordered list. The bind the labels and checkboxes together the pollId and index of the answers is used as id.

Signed-off-by: Joshua Irmer <irmer@gonicus.de>
Signed-off-by: Joshua Irmer <irmer@gonicus.de>
Signed-off-by: Joshua Irmer <irmer@gonicus.de>
@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@joshuai96
Copy link
Contributor Author

Drafting to address unsuccessful checks

@joshuai96 joshuai96 marked this pull request as draft February 20, 2025 15:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants