Invite dialog fixes #4304
Merged
Invite dialog fixes #4304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virtuacoplenny
previously approved these changes
Jun 5, 2019
react/features/invite/components/add-people-dialog/native/AddPeopleDialog.js
Outdated
Show resolved
Hide resolved
virtuacoplenny
approved these changes
Jun 6, 2019
saghul
reviewed
Jun 11, 2019
| // HOWEVER: We don't want to show poltergeist or other bot type participants on stage | ||
| // automatically, because it's misleading (users may think they are already | ||
| // joined and maybe speaking). | ||
| for (let i = participants.length; i > 0 && !participant; i--) { |
There was a problem hiding this comment.
We could use that, but not sure if that would help, because that goes through all the elements, and now that we have this reverse order, we can shortcircuit the loop
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.