Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: make artisan command package:discover turn off for processors by default. #2

Closed
wants to merge 1 commit into from

Conversation

chrisLeeTW
Copy link

This pull request will make artisan command package:discover bypass for the processors.

Original config will make curl exception during the composer install if laravel-profiler is not started.

   GuzzleHttp\Exception\ConnectException  : cURL error 6: Could not resolve: profiler (Domain name not found) (see http://curl.haxx.se/libcurl/c/libcurl-errors.html)

  at /Users/chris_lee/WorkZone/GitZone/GetokenCode/revolution/revolution-backend/vendor/guzzlehttp/guzzle/src/Handler/CurlFactory.php:185
    181|         );
    182|
    183|         // Create a connection exception if it was a specific error code.
    184|         $error = isset($connectionErrors[$easy->errno])
  > 185|             ? new ConnectException($message, $easy->request, null, $ctx)
    186|             : new RequestException($message, $easy->request, $easy->response, null, $ctx);
    187|
    188|         return \GuzzleHttp\Promise\rejection_for($error);
    189|     }

  Exception trace:

  1   GuzzleHttp\Handler\CurlFactory::createRejection(Object(GuzzleHttp\Handler\EasyHandle))
      /Users/chris_lee/WorkZone/GitZone/GetokenCode/revolution/revolution-backend/vendor/guzzlehttp/guzzle/src/Handler/CurlFactory.php:149

  2   GuzzleHttp\Handler\CurlFactory::finishError(Object(GuzzleHttp\Handler\CurlHandler), Object(GuzzleHttp\Handler\EasyHandle), Object(GuzzleHttp\Handler\CurlFactory))
      /Users/chris_lee/WorkZone/GitZone/GetokenCode/revolution/revolution-backend/vendor/guzzlehttp/guzzle/src/Handler/CurlFactory.php:102

  Please use the argument -v to see more details.

@coveralls
Copy link

coveralls commented May 26, 2019

Pull Request Test Coverage Report for Build 63

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 59: 0.0%
Covered Lines: 820
Relevant Lines: 820

💛 - Coveralls

@jkocik
Copy link
Owner

jkocik commented Nov 21, 2019

Thanks for that PR but I don't want to exclude any framework actions by default.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants