Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Skip drawing the line for negative values in log plots #34

Merged
merged 3 commits into from
Nov 29, 2019

Conversation

certik
Copy link
Contributor

@certik certik commented Nov 26, 2019

No description provided.

@certik certik changed the title Skip drawing the line for negative values Skip drawing the line for negative values in log plots Nov 26, 2019
@jkriege2
Copy link
Owner

Hi and thanks for the contribution ... i have two requests:

  1. Please post a Screenshot of the old vs. The fixed plots that illustrate the problem and solution
  2. Why do you use a vector of uniqe_ptr instead of a simple vector of polygons?
    Best, jan

@certik
Copy link
Contributor Author

certik commented Nov 29, 2019

Regarding 1., here are two screenshots of the current behavior. It's the same graph moved using the "hand" tool:

old1
old2

as you can see, the graph changed it's shape simply by moving it. That is not optimal.

In this PR, the graph looks like this:

new

and it is invariant when you move it around with the "hand" tool. As it should be. Matplotlib has the same behavior as this PR.

@certik
Copy link
Contributor Author

certik commented Nov 29, 2019

Regarding 2., that was fixed in ae722e8.

@jkriege2 jkriege2 merged commit ee4262d into jkriege2:master Nov 29, 2019
@jkriege2
Copy link
Owner

OK!

great addition!

Thanks,
JAN

@certik certik mentioned this pull request Dec 2, 2019
@certik certik deleted the log_zero2 branch May 20, 2020 04:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants