Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix exporter panic on whitespace in metric name and add a test case. #12

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

HackToHell
Copy link
Contributor

What this PR does / why we need it

Virtual Machine metrics contain metric names with whitespace in them.,

Which issue this PR fixes

Adds a test case.

Notes

Open to replacing space with a underscore as well.

Checklist

  • [ x] DCO signed
  • [ x] The PR title has a summary of the changes
  • [ x] The PR body has a summary to reflect any significant (and particularly user-facing) changes introduced by this PR

Signed-off-by: gowtham <gowtham.sundara@gopuff.com>
@jkroepke
Copy link
Owner

Q: where did you find this project?

@jkroepke jkroepke added the 🐞 bug Something isn't working label Jun 19, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.86%. Comparing base (18a6769) to head (d09d54a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #12   +/-   ##
=======================================
  Coverage   36.86%   36.86%           
=======================================
  Files           8        8           
  Lines         575      575           
=======================================
  Hits          212      212           
  Misses        325      325           
  Partials       38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: gowtham <gowtham.sundara@gopuff.com>
@HackToHell HackToHell force-pushed the gowtham/fix_whitespace branch from f916d08 to d09d54a Compare June 20, 2024 16:45
@HackToHell
Copy link
Contributor Author

Q: where did you find this project?
I was trying to write a version of the exporter with the batch API and was looking in github search and found this.

@jkroepke jkroepke merged commit 83343d6 into jkroepke:main Jun 20, 2024
5 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants