Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Form inputs #66

Merged
merged 4 commits into from
Sep 1, 2024
Merged

Form inputs #66

merged 4 commits into from
Sep 1, 2024

Conversation

joykangangi
Copy link
Collaborator

New Form Input Implementations:

  • CardFormatter
  • DateFormatter
Valid Input Invalid Input
valid invalid

@joykangangi
Copy link
Collaborator Author

  • Added Validator.Date functionality to verify the validity of dates entered in the input fields.
  • Introduced the usage of Java 8 date and time classes (DateTimeFormatter and LocalDate) for date validation.
  • Modified enum class DateFormat to align with the recognized patterns in the Java 8 DateTimeFormatter.
  • Implemented exact date resolving using ResolverStyle.STRICT to ensure accurate validation without any automatic correction.
  • Conducted testing of the date validation functionality with various test cases.
  • Improved consistency by removing the phone input field and adjusting validateSurvey and validateScreen to accommodate three input fields per screen.

LinusMuema
LinusMuema reviewed Jul 9, 2023
View reviewed changes
example/src/main/java/com/dsc/formbuilder/screens/survey/components/PersonalDetails.kt
TextFieldState("phone"),
TextFieldState(
"date",
formatter = DateFormatter(dateFormat = DateFormat.DDMMYYYY, separator = "/"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome to see that the preview is actually interactive and applies our formatters 😎

LinusMuema
LinusMuema approved these changes Jul 9, 2023
View reviewed changes
Copy link
Collaborator

@LinusMuema LinusMuema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff. All tests passing.
Thanks for this.

@joykangangi joykangangi merged commit 9115d66 into develop Sep 1, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@LinusMuema LinusMuema LinusMuema approved these changes

@OtienoSamwel OtienoSamwel Awaiting requested review from OtienoSamwel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joykangangi @LinusMuema