Make options menu scrollable #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 22, 2022 12:45
jkuester
approved these changes
Jun 15, 2022
There was a problem hiding this comment.
🚀
For future me (or anyone else interested), I did some reading on ScrollView vs RecyclerView and it boils down to if you have a large collection of the exact same thing, it can be more performant to use a RecyclerView, but if you just need a scrollable screen to hold random things, ScrollView is probably what you want.
jkuester
pushed a commit
that referenced
this pull request
Jun 15, 2022
Co-authored-by: bakio86 <bakio86@mi.fu-berlin.de> (cherry picked from commit f4c6ce2)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #83
Adds
ScrollViewin the options menu.