Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(#190): hide uninstall option if app is system app. #198

Merged

Conversation

hayribakici
Copy link

@hayribakici hayribakici commented Dec 30, 2023

This PR fixes #190

I chose to just hide the uninstall option, because default launchers on android do the same. However, changing to put a notification instead should be doable with these given changes.

Copy link
Owner

@jkuester jkuester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most excellent! Confirmed that this works on Android 5 and Android 14!

@jkuester jkuester changed the title (feat) Hide uninstall option if app is system app. fix(#190): hide uninstall option if app is system app. Dec 30, 2023
@jkuester jkuester merged commit 0115a1c into jkuester:master Dec 30, 2023
1 check passed
@hayribakici hayribakici deleted the #190_disable_uninstall_system_app branch December 30, 2023 15:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notify when cannot unintall app
2 participants