Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jline Nano unresponsive upon line overflow #120

Closed
abcnet opened this issue Apr 27, 2017 · 5 comments
Closed

Jline Nano unresponsive upon line overflow #120

abcnet opened this issue Apr 27, 2017 · 5 comments

Comments

@abcnet
Copy link

abcnet commented Apr 27, 2017

I found a bug in Jline Nano editor. When we type enough characters until they do not fit in one line, Nano editor will become unresponsive.
Jline_Nano_Bug_Report.zip

The zip archive contains the minimal code that reproduces the error. To build and run:

mvn package
java -cp target/jline-nano-bug-1.0.jar com.NanoBug

I appreciate it if the problem could be resolved.

Also, can you please make the constructor of Nano.Buffer class protected so that we can extend it?

    Buffer(String file) {
        this.file = file;
    }

Thanks a lot!

@gnodet
Copy link
Member

gnodet commented Apr 28, 2017

Just for curiosity, what do you want to change in the Nano.Buffer class ?

@gnodet gnodet closed this as completed in 43b443b Apr 28, 2017
@gnodet
Copy link
Member

gnodet commented Apr 28, 2017

I've disabled non-wrapping mode, as it's clearly not working.

gnodet added a commit that referenced this issue Apr 28, 2017
@abcnet
Copy link
Author

abcnet commented Apr 28, 2017

Hi, I want to add a "protected" specifier to

    Buffer(String file) {
        this.file = file;
    }

Like this:

    protected Buffer(String file) {
        this.file = file;
    }

So that I can extend the inner nested class. Thanks!

@gnodet
Copy link
Member

gnodet commented Apr 28, 2017

Have you checked the commit 43b443b ?

@abcnet
Copy link
Author

abcnet commented Apr 28, 2017

Sorry I missed that. Thank you!

mattirn added a commit to mattirn/jline3 that referenced this issue Jul 29, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants