Feature/produce nuget for fs sonar runner core #101

jmecosta · 2020-06-30T14:05:20Z

#75 update linter on sonar extensions

milbrandt · 2020-06-30T14:40:40Z

You need this as a nuget in some other place? Should this be permanently generated or only for working? If permanently I would propose to add it to the release notes.
Maybe we should make a minor release 3.1.1 anyway now that the deprecated api is removed.

appveyor.yml

jmecosta · 2020-06-30T14:50:57Z

Basically because we dont know if this number upgrades has changes on the f# side i would rather have it created all the time.

…

On Tue, 30 Jun 2020, 17:48 Jorge Costa, ***@***.***> wrote: Yeah, im kind of copy pasting the code on the visual studio extension, so its best just to reuse this. On Tue, 30 Jun 2020, 17:40 Volker Milbrandt, ***@***.***> wrote: > You need this as a nuget in some other place? Should this be permanently > generated or only for working? If permanently I would propose to add it to > the release notes. > Maybe we should make a minor release 3.1.1 anyway now that the deprecated > api is removed. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#101 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAH6HSEQGPICZASRINW5HS3RZH2PRANCNFSM4OMIVKLQ> > . >

jmecosta · 2020-06-30T14:55:59Z

I wouldnt mind, but then everything needs to be major.minor.buildnumber

…

On Tue, 30 Jun 2020, 17:48 Volker Milbrandt, ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In appveyor.yml <#101 (comment)> : > @@ -30,9 +30,9 @@ dotnet_csproj: file: '**\*.csproj;**\*.props;**\*.fsproj;**\*.xml' version: '{version}' package_version: '{version}' - assembly_version: '{version}' - file_version: '{version}' - informational_version: '{version}' + assembly_version: '{version}.0' shouldn't we change the version in line 8 accordingly and from here keep only reference? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#101 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAH6HSAMIUSPZWY44GDL6H3RZH3MZANCNFSM4OMIVKLQ> .

milbrandt · 2020-06-30T15:02:55Z

I wouldnt mind, but then everything needs to be major.minor.buildnumber

You wanted to reference on my review comment above? My proposal was be to define in line 8:

version: 3.1.{build}.0

and then revert

assembly_version: '{version}'
file_version: '{version}'	
informational_version: '{version}'

If ommitting the last .0 helps, it's fine for me.

I would prefer if all version stings are identical - so there can't be any misconceptions in case of bugs.

jmecosta · 2020-06-30T16:54:07Z

Yep, the last 0 then needs to go.

…

On Tue, 30 Jun 2020, 18:03 Volker Milbrandt, ***@***.***> wrote: I wouldnt mind, but then everything needs to be major.minor.buildnumber You wanted to reference on my review comment above? My proposal was be to define in line 8: version: 3.1.{build}.0 and then revert assembly_version: '{version}' file_version: '{version}' informational_version: '{version}' If ommitting the last .0 helps, it's fine for me. I would prefer if all version stings are identical - so there can't be any misconceptions in case of bugs. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#101 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAH6HSAM2T52YW5GQD7SLOTRZH5C5ANCNFSM4OMIVKLQ> .

milbrandt

Please add some hint to the RELEASE_NOTES.md that plugin versioning changed.

milbrandt · 2020-06-30T19:18:33Z

appveyor.yml

@@ -5,7 +5,7 @@
 #---------------------------------#

 # version format
-version: 3.1.0.{build}
+version: 3.1.{build}


What is now displayed in the SonarQube Server Marketplace as version? Until now it was e.g. 3.1 (build 345)installed

jmecosta · 2020-06-30T20:10:18Z

i think its more accurate since the version is 3.1.0.345 -> goes to 3.1 (build 345) as 1.5.7 -> 1.5.7installed but as far as i can see, i can find 3 types of verison 1. 1.1 2. 1.1.1 3. 1.3 (build x) 4. 1.4.3 (build x)

…

On Tue, Jun 30, 2020 at 10:18 PM Volker Milbrandt ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In appveyor.yml <#101 (comment)> : > @@ -5,7 +5,7 @@ #---------------------------------# # version format -version: 3.1.0.{build} +version: 3.1.{build} What is now displayed in the SonarQube Server Marketplace as version? Until now it was e.g. 3.1 (build 345)installed — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#101 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAH6HSAS34OLHIL4NRUFP3TRZI3BRANCNFSM4OMIVKLQ> .

milbrandt · 2020-07-14T08:33:29Z

Please add some hint to the RELEASE_NOTES.md that plugin versioning changed.

I added now myself some release notes draft

jmecosta · 2020-07-14T09:21:15Z

Miss this one

…

On Tue, 14 Jul 2020, 11:34 Volker Milbrandt, ***@***.***> wrote: Assigned #101 <#101> to @jmecosta <https://github.com/jmecosta>. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#101 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAH6HSH25EUBHKNIHFJP46DR3QKAVANCNFSM4OMIVKLQ> .

milbrandt · 2020-07-20T16:17:17Z

Miss this one

@jmecosta you will continue this PR?
Do you intend to publish the new package to nuget.org?
Shall we release a version because of the changed versioning scheme as soon as the PR is merged?

jmecosta · 2020-07-20T16:42:50Z

Yep, i will take care of it later today

…

On Mon, 20 Jul 2020, 19:17 Volker Milbrandt, ***@***.***> wrote: Miss this one @jmecosta <https://github.com/jmecosta> you will continue this PR? Do you intend to publish the new package to nuget.org? Shall we release a version because of the changed versioning scheme as soon as the PR is merged? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#101 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAH6HSB56JTRPTDOGQBSBJDR4RUZ5ANCNFSM4OMIVKLQ> .

jmecosta · 2020-07-20T19:43:49Z

@milbrandt since there are not functional changes i think we can skip this change and just release when we have more stuff coming in

jmecosta · 2020-07-20T19:57:34Z

nuget published https://www.nuget.org/packages/FsSonarRunnerCore/3.1.382

milbrandt · 2020-07-20T20:15:03Z

@milbrandt since there are not functional changes i think we can skip this change and just release when we have more stuff coming in

@jmecosta you're right that this PR didn't change functionality.
But since 3.1.0 in March there were several changes. And SonarQube wants an release at least every 6 month. All togerther I think we could do a service release 3.1.382 to have the same versioning scheme for the released plugin as for nuget.
Publishing to nuget.org is not automated in the yaml pipeline as far as I saw?

jmecosta · 2020-07-21T08:09:28Z

Ok lets than do the release. I will check the auto deploy of nuget

…

On Mon, 20 Jul 2020, 23:15 Volker Milbrandt, ***@***.***> wrote: @milbrandt <https://github.com/milbrandt> since there are not functional changes i think we can skip this change and just release when we have more stuff coming in @jmecosta <https://github.com/jmecosta> you're right that this PR didn't change functionality. But since 3.1.0 in March there were several changes. And SonarQube wants an release at least every 6 month. All togerther I think we could do a service release 3.1.382 to have the same versioning scheme for the released plugin as for nuget. Publishing to nuget.org is not automated in the yaml pipeline as far as I saw? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#101 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAH6HSDUTHI3NHYL2Y6L2O3R4SQVPANCNFSM4OMIVKLQ> .

#101 publish nuget package

jmecosta · 2020-07-21T08:40:14Z

@milbrandt should all be done now, 3.1.384 is now the only version in every place

milbrandt · 2020-07-21T16:55:04Z

👍

jmecosta added 2 commits June 30, 2020 17:02

produce package to take to visual studio extension

4ca99b6

add nupkg to artifacts

3786905

jmecosta requested a review from milbrandt June 30, 2020 14:05

use sem version 2.0.0 - to expose nuget package

f1474b0

This comment has been minimized.

# to view

milbrandt reviewed Jun 30, 2020

View reviewed changes

appveyor.yml Outdated Show resolved Hide resolved

remove leading zeros

dbae44e

milbrandt requested changes Jun 30, 2020

View reviewed changes

milbrandt reviewed Jun 30, 2020

View reviewed changes

milbrandt added 3 commits July 14, 2020 09:18

Merge branch 'master' into feature/produce-nuget-for-FsSonarRunnerCore

8d3b262

set some properties for the nuget package

bfb8522

prepare release notes

d6635b0

milbrandt approved these changes Jul 14, 2020

View reviewed changes

milbrandt assigned milbrandt and jmecosta and unassigned milbrandt Jul 14, 2020

Update RELEASE_NOTES.md

88184d6

jmecosta merged commit b03ccc5 into master Jul 20, 2020

jmecosta added a commit that referenced this pull request Jul 21, 2020

Update appveyor.yml

234d10d

#101 publish nuget package

jmecosta added a commit that referenced this pull request Jul 21, 2020

#101 fix build

8576ce0

milbrandt deleted the feature/produce-nuget-for-FsSonarRunnerCore branch October 20, 2020 19:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/produce nuget for fs sonar runner core #101

Feature/produce nuget for fs sonar runner core #101

jmecosta commented Jun 30, 2020

milbrandt commented Jun 30, 2020

This comment has been minimized.

jmecosta commented Jun 30, 2020 via email

jmecosta commented Jun 30, 2020 via email

milbrandt commented Jun 30, 2020

jmecosta commented Jun 30, 2020 via email

milbrandt left a comment

milbrandt Jun 30, 2020

jmecosta commented Jun 30, 2020 via email

milbrandt commented Jul 14, 2020

jmecosta commented Jul 14, 2020 via email

milbrandt commented Jul 20, 2020

jmecosta commented Jul 20, 2020 via email

jmecosta commented Jul 20, 2020

jmecosta commented Jul 20, 2020

milbrandt commented Jul 20, 2020

jmecosta commented Jul 21, 2020 via email

jmecosta commented Jul 21, 2020

milbrandt commented Jul 21, 2020

Feature/produce nuget for fs sonar runner core #101

Feature/produce nuget for fs sonar runner core #101

Conversation

jmecosta commented Jun 30, 2020

milbrandt commented Jun 30, 2020

This comment has been minimized.

jmecosta commented Jun 30, 2020 via email

jmecosta commented Jun 30, 2020 via email

milbrandt commented Jun 30, 2020

jmecosta commented Jun 30, 2020 via email

milbrandt left a comment

Choose a reason for hiding this comment

milbrandt Jun 30, 2020

Choose a reason for hiding this comment

jmecosta commented Jun 30, 2020 via email

milbrandt commented Jul 14, 2020

jmecosta commented Jul 14, 2020 via email

milbrandt commented Jul 20, 2020

jmecosta commented Jul 20, 2020 via email

jmecosta commented Jul 20, 2020

jmecosta commented Jul 20, 2020

milbrandt commented Jul 20, 2020

jmecosta commented Jul 21, 2020 via email

jmecosta commented Jul 21, 2020

milbrandt commented Jul 21, 2020