Support root level wildcards #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ElementsBranch node has been removed, it can be represented
with the new WildcardIndex. Previously foo[0] and foo[*] parsed
to two different structures. Now both use a SubExpression node and
the wildcard is just represented as a WildcardIndex instead of an
Index node::
SubExpression(AST(...), WildcardIndex())
Which makes the constructed ASTs more consistent.
I've also updated the parser grammar to not require separate rules
for root indices vs. indices in a subexpression.
Similar to wildcard index simplification, now
foo.* is written with a subexpression node::
SubExpression(Field(foo), WildcardValues())
where WildcardValues just multimatches the values of the dict.
This also simplified the grammar such that another rule could be
collapsed into the existing subexpression rule.
Fixes #4. This also cleans up some of the grammar rules:: expression : subexpression : STAR subexpression : expression DOT expression
|
🎉 |
|
🚢 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4
This PR also cleans up some of the grammar and fixes some of the quirky parts of the AST. The simplified subexpression grammar is roughly:
I also removed the
ElementsBranchandValuesBranchwhich was unnecessary. The parsing rules have been unified to just used subexpressions so instead ofElementsBranch(Field(foo))it's justSubExpression(Field(foo), WildcardIndex())forfoo[*]. Similar thing forWildcardValues. This means that root level wildcards (in the case of a subexpression) is justSubExpression(WildcardValues(), Field(foo))which has a nice symmetry to the now simplified inverted rule forfield.*:SubExpression(Field(foo), WildcardValues())