Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

Purge autoremoved packages and exclude resolv.conf #18

Merged
merged 2 commits into from
Dec 9, 2016

Conversation

szepeviktor
Copy link
Contributor

No description provided.

@szepeviktor
Copy link
Contributor Author

@jmtd Could you please merge this?

@jmtd
Copy link
Owner

jmtd commented Dec 5, 2016

Hi, I am happy with --purge but I'm not sure why removing resolv.conf is a good idea.

@szepeviktor
Copy link
Contributor Author

Hi, I am happy with --purge but I'm not sure why removing resolv.conf is a good idea.

Because Docker bind-mounts that file.

@jmtd
Copy link
Owner

jmtd commented Dec 5, 2016

Because Docker bind-mounts that file.

Sure, so the old copy in the filesystem is irrelevant. But why remove it? Is docker not bind-mounting during a build too -- I thought it was (each build step is executed as a container)

If the rationale is image size, this won't make the image smaller; but it will make the layer delta larger.

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Dec 5, 2016

the rationale is

This file seems like trash, and it contains the builder's resolvers.

@szepeviktor
Copy link
Contributor Author

it will make the layer delta larger.

Yes. Could it be removed in the makefile?
https://github.com/jmtd/debian-docker/blob/master/Makefile#L37

@jmtd
Copy link
Owner

jmtd commented Dec 5, 2016

This file seems like trash, and it contains the builder's resolvers.

Ah that's a good point, it could be a privacy problem to leak that into the images.

Yes. Could it be removed in the makefile?

I think I prefer that. Could you please remove it from this PR (then I will happily apply this PR) and we can either raise a separate issue or a separate PR for the resolv.conf file.

Thanks for working on this! Sorry I haven't put much into it in recent times.

@szepeviktor
Copy link
Contributor Author

Done.

@jmtd jmtd merged commit 5c57399 into jmtd:master Dec 9, 2016
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants