Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[BUG]: plug numbers do not match #243

Closed
ingo916 opened this issue Jan 25, 2021 · 2 comments · Fixed by #264
Closed

[BUG]: plug numbers do not match #243

ingo916 opened this issue Jan 25, 2021 · 2 comments · Fixed by #264
Labels
enhancement New feature or request solved workaround documented or fix applied
Milestone
1.0.0

Comments

@ingo916
Copy link

ingo916 commented Jan 25, 2021 •
edited
Loading

Describe the bug
In the TP-Link Kasa app, the outlets on my HS300 are listed as 1-6 as shown in the following screenshot.
However in the plugin it's off, 1 would be outlet 2 on the power strip then 2 would be outlet 3 and so on.
Screenshots
FD47C4C1-4503-46C6-A7C6-EDBE83D798BE

  • OctoPrint Version 1.5.3
  • Plugin Version 0.9.26
  • TP-Link Firmware 1.0.19
@jneilliii
Copy link
Owner

The instructions for multiple plug/strip devices is to use a 0 based number, so for now you should be able to subtract 1 from the number listed in the plugin's settings.

@jneilliii jneilliii added the enhancement New feature or request label Jan 25, 2021
@jneilliii jneilliii added this to the 1.0.0 milestone Jan 27, 2021
jneilliii added a commit that referenced this issue Feb 28, 2021
@jneilliii
change index values for strip devices to match labels and the Kasa app,
0aa3f35 
#243
@jneilliii
Copy link
Owner

adjusted code in above commit to match the index to the labels shown on the device and in the app, you can switch the release channel to Release Candidate in OctoPrint's software update settings and upgrade when prompted to try it out. @tideline3d may be interested in this one as well 😄

@jneilliii jneilliii added the solved workaround documented or fix applied label Feb 28, 2021
@jneilliii jneilliii mentioned this issue Apr 14, 2021
Merged
jneilliii added a commit that referenced this issue Apr 14, 2021
@jneilliii
1.0.0 (#264)
7f1bb1b 
* clear _autostart_file on print done or canceled events to prevent from auto starting a file on next connect.
* fix missing poll_status in init
* resolve idle timeout issues related to plugs powering off with gcode commands, #254
* change gcode trigger logic for off commands to account for printer buffer, #258
* change index values for strip devices to match labels and the Kasa app, #243
* add sending gcode commands before off and after on, #160, #170
* turn on only if we are closed or errored state with upload event, thanks to @ayufan
* added shutdown event monitoring, #263
* add API endpoint for listing configured plugs
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement New feature or request solved workaround documented or fix applied
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

1.0.0 jneilliii/OctoPrint-TPLinkSmartplug
2 participants
@jneilliii @ingo916