-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Feat: Performance enhancements #281
base: main
Are you sure you want to change the base?
Feat: Performance enhancements #281
Conversation
@fveracoechea is attempting to deploy a commit to the cva Team on Vercel. A member of the Team first needs to authorize it. |
This is super thoughtful of you, thanks @fveracoechea 🙏❤️ Fairly busy at the moment and this will take some time to review, so don't be too disheartened if it takes some time to get around to this! Really appreciate it |
Thanks @joe-bell 🙏 let me know if you have any suggestions or concerns, I’d be happy to help! |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Hey @fveracoechea, just wanted to give you a quick update rather than leave you in the dark here! I'm starting to pick up For now, I'm going to hold off merging this simply because it's a little easier to work with the code I'm familiar with That said, I'm keeping this PR open as I don't want to discourage you from introducing your improvements – which are incredibly valuable! I'll keep you posted on |
Thanks @joe-bell, I appreciate the update, it totally makes sense, I'll be happy to revisit it when the timing works better. |
New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/react@18.2.0, npm/sharp@0.33.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to mention, this file is just for benchmarking purposes, basically making sure these changes are actually faster, could be removed before merging.
Description
Implement code optimizations on CVA to increase execution speed and reduce the number of operations, such as iterations and object copying.
Additional context
Let's say we have a web page made of React components, where most components utilize CVA.
Since React components render and re-render often, it's important to keep CVA's runtime overhead as low as possible. This optimization will enhance scalability, especially on large projects.
Benchmark results
All tests passing with no problems:
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).