Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: readme example #70

Merged
merged 1 commit into from
Nov 22, 2022
Merged

fix: readme example #70

merged 1 commit into from
Nov 22, 2022

Conversation

TmLev
Copy link
Contributor

@TmLev TmLev commented Nov 22, 2022

Description

I think one example from README is a bit off:

export type ButtonVariantProps = VariantProps<typeof button>; // Should be `typeof buttonVariants`.
export const buttonVariants = cva("…", ...);

export const button = (props: ButtonProps) => buttonVariants(props);

Additional context


What is the purpose of this pull request?

Fix the example.

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the Style Guide.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

@joe-bell
Copy link
Owner

Thank you!

@joe-bell joe-bell changed the title fix: Readme example fix: readme example Nov 22, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants