Fix for MSYS2 #3
Conversation
| @@ -8,7 +8,7 @@ if [[ -z $PARUZ ]]; then | |||
| elif ! command -v pacman >/dev/null 2>&1; then | |||
| echo "Neither paru nor pacman found. Is this Arch?" >&2 | |||
| exit 1 | |||
| elif [[ $EUID -eq 0 ]]; then | |||
| elif [[ $EUID -eq 0 ]] || [[ -f /usr/bin/msys-2.0.dll ]]; then | |||
There was a problem hiding this comment.
You don't need to special case msys2. It's fixed by your next commit.
There was a problem hiding this comment.
There's no sudo on MSYS2. So we need to use just 'pacman'.
There was a problem hiding this comment.
Are you able to set environment variables? If so, try setting PARUZ=pacman
There was a problem hiding this comment.
Sorry, I'm a bit confused. Isn't PARUZ being set to pacman here in the next line itself? I can set environment variables, but I'm unable to understand the need for it. (The Readme tells us that we explicitly set PARUZ when we want to use a different helper, but this is just pacman.)
There was a problem hiding this comment.
I'm trying to fix your problem without a special case for MSYS2. If you export PARUZ=pacman in your shell, then it won't do the root check or try sudo pacman.
There was a problem hiding this comment.
I'm again trying too understand what's the harm in having a special case (genuine question). If it's an implementation problem, see my comment below.
There was a problem hiding this comment.
Does the environment variable work?
There was a problem hiding this comment.
Yes, it does.
But I find having to define PARUZ as 'pacman' slightly cumbersome, more so because there's already a fallback to 'pacman' in the script itself.
There's already a condition running in the if block there. Would it be considered really bad if we just put another OR check there? (Sorry again, I'm just trying to understand. I get that PRVW_CMD was slightly invasive as a platform-specific fix, so I removed it as per your instructions. But isn't this one really insignificant in comparison?)
There was a problem hiding this comment.
Adding an environment variable shouldn't be cumbersome. I have like 100 environment variables in my shell config. This scenario is exactly why I added the variable.
There was a problem hiding this comment.
Paruz was made to handle paru and pacman (as I understand from the script). I would have happily set the environment variable if I was using some other helper (as the Readme tells us).
I will remove this condition if this feels really unnecessary.
MSYS2 uses pacman. This includes a tiny fix for it.
Also closes #2
Tested on Arch Linux and MSYS2