Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Library projects should use android.libraryVariants instead of android.applicationVariants #391

Merged

Conversation

jophde
Copy link
Contributor

@jophde jophde commented Jul 16, 2015

I couldn't get my library project to build. The issue was the plugin was calling android.applicationVariants always. For library projects it should be android.libraryVariants.

Josh Deffibaugh added 2 commits July 15, 2015 12:04
Previous version crashes for library projects because it is trying to call project.android.applicationVariants when that property does not exist.
joelittlejohn added a commit that referenced this pull request Jul 16, 2015
@joelittlejohn joelittlejohn merged commit 4fa6132 into joelittlejohn:master Jul 16, 2015
@joelittlejohn
Copy link
Owner

Thanks!

@joelittlejohn joelittlejohn changed the title Jophde fix lib projects Library projects should use android.libraryVariants instead of android.applicationVariants Jul 16, 2015
@joelittlejohn joelittlejohn added this to the 0.4.14 milestone Jul 16, 2015
@jophde
Copy link
Contributor Author

jophde commented Jul 20, 2015

When do you expect to be pushing a new release with this change?

@dadrus dadrus mentioned this pull request Jan 14, 2016
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants