Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[FIX] Switch Characteristics code to promise-based functions #563

Open
johannrichard opened this issue Dec 29, 2022 · 0 comments
Open

[FIX] Switch Characteristics code to promise-based functions #563

johannrichard opened this issue Dec 29, 2022 · 0 comments
Assignees
@johannrichard
Labels
enhancement New feature or request

Comments

@johannrichard
Copy link
Owner

Describe the enhancement
Consider using the promise-based Characteristic.onGet and Characteristic.onSet method instead of the current Characteristic.onmethods.

Examples and context

homebridge-dingz/src/dingzAccessory.ts

Lines 339 to 342 in f724931

// create handlers for required characteristics
temperatureService
.getCharacteristic(this.platform.Characteristic.CurrentTemperature)
.on(CharacteristicEventTypes.GET, this.getTemperature.bind(this));

Additional context
See Homebridge Characteristics documentation.
@johannrichard johannrichard added the enhancement New feature or request label Dec 29, 2022
@johannrichard johannrichard self-assigned this Dec 29, 2022
@johannrichard johannrichard changed the title [FIX] Switch Characteristics code to promise based functions [FIX] Switch Characteristics code to promise-based functions Dec 29, 2022
johannrichard added a commit that referenced this issue Dec 29, 2022
@johannrichard
fix(accessory): 🐛 fix for #563 - improve callback robustness
a206e9a 
Close #562
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@johannrichard johannrichard

Labels
enhancement New feature or request
Projects
Homebridge Plugin
Status: To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johannrichard