Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update views.* endpoints to use POST method instead of GET #146

Merged
merged 2 commits into from
Mar 30, 2022
Merged

Update views.* endpoints to use POST method instead of GET #146

merged 2 commits into from
Mar 30, 2022

Conversation

matthewnessworthy
Copy link
Contributor

Fixes #111
Replaces #130 (because of merge conflicts)

First updated the SDK with the latest updates

rm -Rf generated/*
vendor/bin/jane-openapi generate --config-file=.jane-openapi.php
./bin/slack-api-client-generator spec:generate-patch
./bin/slack-api-client-generator spec:update

Then after updating the relevant HTTP methods in resources/slack-openapi-patched.json

./bin/slack-api-client-generator spec:generate-patch
./bin/slack-api-client-generator spec:update
vendor/bin/jane-openapi generate --config-file=.jane-openapi.php

@matthewnessworthy
Copy link
Contributor Author

@damienalexandre please review

@damienalexandre
Copy link
Member

#147 has been merged, you have to rebuild this PR from "main". Sorry about that 😋

@matthewnessworthy
Copy link
Contributor Author

@damienalexandre no worries, all done

Copy link
Member

@damienalexandre damienalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method on viewPublish/viewPush/viewUpdate is still "GET" but the parameters have been changed to "form parameter", am I missing something? viewOpen looks good.

@damienalexandre damienalexandre merged commit f0777a4 into jolicode:main Mar 30, 2022
@damienalexandre
Copy link
Member

Thanks a lot!

@matthewnessworthy
Copy link
Contributor Author

Glad i could help, thanks for the support and hand-holding!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request-URI Too Large
3 participants