Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Ruby 2.7 compatibility #23

Closed
MartinodF opened this issue Jun 10, 2020 · 1 comment
Closed

Ruby 2.7 compatibility #23

MartinodF opened this issue Jun 10, 2020 · 1 comment

Comments

@MartinodF
Copy link
Contributor

new_ostruct_member has been removed from OpenStruct in ruby 2.7.
This breaks FilePreviews::Response.responsify, which relies on it.

This change also impacted rubyconfig/config, and was resolved via rubyconfig/config#255 (by simply removing the method call, if I understand it correctly).

I'm preparing a PR with this change, having tested it in both 2.4.1 and 2.7.1 by running rspec and having no errors. I'm not really sure if this would impact older ruby versions, or something not covered by the specs.

Let me know if you see any issue with this approach!
MartinodF added a commit to tribecommunication/filepreviews-ruby that referenced this issue Jun 10, 2020
@MartinodF
Ruby 2.7 compatibility (fixes jonahoffline#23)
cd2ba53
@jonahoffline
Copy link
Owner

Hi @MartinodF

This looks great. I tested it against 2.4.1, 2.5.1, 2.6.5, and 2.7.1 and everything is working as expected. Thank you so much, I will be doing a release soon.

jonahoffline added a commit that referenced this issue Jun 17, 2020
@jonahoffline
Merge pull request #24 from shamansrl/ruby-2.7
08f2618 
Ruby 2.7 compatibility (fixes #23)
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MartinodF @jonahoffline