Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Generate better error messages when encountering unexpected i128/u128 values during deserialization #810

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

jonasbb
Copy link
Owner

@jonasbb jonasbb commented Dec 25, 2024

Tests are omitted since they do not work with serde_json. They are treated as large floats.

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 65.84%. Comparing base (4c273b2) to head (e8d2e02).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
serde_with/src/utils.rs 0.00% 18 Missing ⚠️
serde_with/src/de/impls.rs 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #810      +/-   ##
==========================================
- Coverage   66.40%   65.84%   -0.56%     
==========================================
  Files          40       40              
  Lines        2625     2647      +22     
==========================================
  Hits         1743     1743              
- Misses        882      904      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonasbb jonasbb force-pushed the 128-bit-error-messages branch from 1f2f508 to e8d2e02 Compare December 25, 2024 21:07
@jonasbb jonasbb merged commit 9c06ffa into master Dec 25, 2024
22 checks passed
@jonasbb jonasbb deleted the 128-bit-error-messages branch December 25, 2024 21:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant