Removes the dependency on the /bin hardcoded path. #155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code assumes you will want to install binaries at /bin but probably this is not the case if you follow the defaults in composer, which will install them in /vendor/bin.
You now can have the PhantomJs in /vendor/bin if you prefer, or even at any other path, and the Engine will automatically fetch it from the proper path via the PhantomInstaller\PhantomBinary helper class.