Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Removes the dependency on the /bin hardcoded path. #155

Closed
wants to merge 1 commit into from

Conversation

xmontero
Copy link

The original code assumes you will want to install binaries at /bin but probably this is not the case if you follow the defaults in composer, which will install them in /vendor/bin.

You now can have the PhantomJs in /vendor/bin if you prefer, or even at any other path, and the Engine will automatically fetch it from the proper path via the PhantomInstaller\PhantomBinary helper class.

The original code assumes you will want to install binaries at /bin but probably this is not the case if you follow the defaults in composer, which will install them in /vendor/bin.

You now can have the PhantomJs in /vendor/bin if you prefer, or even at any other path, and the Engine will automatically fetch it from the proper path via the PhantomInstaller\PhantomBinary helper class.
@heddn
Copy link

heddn commented Feb 20, 2017

I think the dependency on PhantomInstaller is considered soft. You should check if the class exists before using it, no?

@jonnnnyw
Copy link
Owner

You an use $client->getEngine()->setPath('path/to/phantomjs');. The next major release will remove the PhantomJS installer so this will be a compulsory setting.

@jonnnnyw jonnnnyw closed this Apr 22, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants