New UD Annotatrix logo #386
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Persevere04
commented
Dec 14, 2019
Persevere04
commented
fix typo
Fix table view deleting words
Fix pressing enter disabling navigation
Fix table view not showing dependencies
Fix Autocomplete box width
This way, we don't need to run the compiler independently -- we can just execute the TypeScript files as if they were JavaScript!
The file referenced doesn't even exist anymore :^) IMO, we don't need this key anyway, since we don't expect anyone to use us as a library.. that wouldn't really make sense.
We're always just storing our corpora as JSON, so we don't need any of this sqlite logic. In the future, I could imagine it might be interesting to add this back in, but I think it's better not have to maintain this dead code in the meantime...
Since `client/` and `server/` are now consuming this project directly as TypeScript, we don't have a separate build step anymore.
We don't want to make all this random data available in the browser at runtime...
Functionally, this is equivalent to what we had before, but it makes it a little easier to share the code into the final bundle (otherwise the fact that `notatrix` was its "own project" led to annoying errors with `babel`/`browserify` that didn't seem worth solving...).
Now, this works correctly:
$ npm run test
Rather than crashing the whole application, we can just avoid any
files in `corpora_path` that we don't know how to parse. Obviously,
this isn't great if the file was corrupted somehow (but does contain
data we'd like to keep)...
Tested this by running
$ cat > corpora/issue506.json
{"hello":
$ npm run server # before
SyntaxError: Unexpected end of JSON input
at JSON.parse (<anonymous>)
at /home/kevinmurphy/src/jonorthwash/ud-annotatrix/src/server/list-treebanks.ts:51:55
at Array.map (<anonymous>)
at /home/kevinmurphy/src/jonorthwash/ud-annotatrix/src/server/list-treebanks.ts:48:34
at FSReqCallback.oncomplete (fs.js:192:5)
$ npm run server # after
Failed to parse corpora/issue506.json: SyntaxError: Unexpected end of JSON input
Closes #506.
jonorthwash
temporarily deployed
to
github-pages
jonorthwash
temporarily deployed
to
github-pages
jonorthwash
temporarily deployed
to
github-pages
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.